mreinstein
commented
3 years ago Some follow up notes on this:
- there is some noise in this PR (some extra unneeded commits.) I'm happy to send a clean PR if this looks like something we want
- I made a few small style changes to the code, because it's just really dense and hard to read with everything so squashed together. If we're really against these changes I'm willing to re-submit without those formatting changes.
- while these changes still pass all the existing unit tests, we would need to do a semver major bump if this were to get released.
- if we're going to bother making breaking changes, are there other parser fixes we want to make?
- does it make sense to drop cjs in favor of a pure esm module, since we're making a breaking api change anyway?
fixes:
This changes causes the tests from https://github.com/choojs/hyperx/pull/52/commits/f1803d5443a83a64d169af542e9124d55f105952 to pass, and they've been included too.