search

chrisbu / dartwatch-JsonObject

JsonObject which allows dot notation access to JSON.parse'd objects. Read the article on http://www.dartlang.org/articles/json-web-service/
http://www.dartlang.org/articles/json-web-service/
MIT License
83 stars 25 forks source link

map.keys and map.vales overrides don't match dart M2 sdk changes #17

Closed jptrainor closed 11 years ago

jptrainor commented 11 years ago

The dart map.keys and map.values base class properties declarations changed for M2. They now return Iterable. I make the following changes to make my own code work.

json_object.dart lines: Collection get keys => _objectData.keys; Collection get values => _objectData.values;

Should be Iterable get keys => _objectData.keys; Iterable get values => _objectData.values;

chrisbu commented 11 years ago

On 6 February 2013 14:47, jptrainor notifications@github.com wrote:

Collection get values => _objectData.values;

Should be Iterable get keys => _objectData.keys; Iterable get values => _objectData.values;

Thanks! - I'll take a look.

chrisbu commented 11 years ago

jptrainor - can you ping me a private mail (I can't find a way to contact you via github...)

chrisbu commented 11 years ago

Updated, Thanks!