search

chrisglein / artificial-chat

2 stars 1 forks source link

Port the working support for VersionInfo in this app over to react-native-version-info. #106

Open chrisglein opened 1 year ago

chrisglein commented 1 year ago

Would just be able to use this: https://github.com/tessus/react-native-version-info. It supports Windows... but the old version of RNW. Needs to be patched: https://github.com/tessus/react-native-version-info/blob/master/windows/RNVersionInfo/RNVersionInfoModule.cs

Originally posted by @chrisglein in https://github.com/chrisglein/artificial-chat/issues/72#issuecomment-1467176437

See implementation here: https://github.com/chrisglein/artificial-chat/blob/main/windows/artificialChat/VersionInfo.h

chrisglein commented 1 year ago

Looks like react-native-device-info provides what we need here: https://github.com/react-native-device-info/react-native-device-info#getversion https://github.com/react-native-device-info/react-native-device-info/blob/master/windows/code/RNDeviceInfoCPP.h

Still worth contributing back to react-native-version-info? Maybe. It is broken without a commit.