Open chrisglein opened 1 year ago
Latest comparison of Paper to Fabric:
Paper | Fabric |
---|---|
Technically the left version was on the #114 branch, so it's not quite apples to apples. And the size difference is due to running on different machines. But it gives you the gist.
That previous set of screenshots was across 2 different machines with different resolutions. Here's a more apples to apples comparison (both running side by side on same dev box):
Paper | Fabric |
---|---|
For the dialogs, the Paper version was using the RNW Popup
component, which doesn't exist in Fabric. Alongside some other control dependencies like Picker
. So there are some placeholders here in the meantime:
Paper | Fabric |
---|---|
Are we missing a border in those tables? (The horizontal lines) Any idea what that is? I thought our border implementation on fabric is actually more complete than the paper one.
Are we missing a border in those tables? (The horizontal lines) Any idea what that is? I thought our border implementation on fabric is actually more complete than the paper one.
Yeah, I had noticed that one but haven't had a chance to dig in yet. I'm using a JS-only module for markdown rendering, and the styling for those tables should be here. That table element is using borderBottomWidth
. So it appears that in Fabric the borderBottomWidth
isn't registering. It's marked as completed in the table, so I assume there's a bug somewhere in the handling. I'll poke around and open a bug to track this (update: here's the bug).
Would probably be possible to merge this sooner if there was the ability to have file redirects for fabric components. Example: mycomponent.windows.fabric.js.
Grabbing the latest Canary build with some fixes that have happened, the addition of color emojis is great. Accessibility information is starting to come online too, so we can start looking at those gaps.
Paper | Fabric |
---|---|
On canary 694:
Paper | Fabric |
---|---|
Brought in latest canary (761) and we have a working scrollbar now:
Summary
Started with this as a basis: https://github.com/chiaramooney/sample-fabric But in 0.73+ this is now replaced with the official app template: https://github.com/microsoft/react-native-windows/wiki/Using-the-new-architecture-templates
Plan
Picker
andPopup
Markdown
working again, for example)Clipboard
AsyncStorage
.png
assets to.ico
filesIssues Found
onAccessibilityTap
)ScrollView
does not display a scroll barScrollView
cannot be controlled with keyboard events (page up, page down, home, end)Not Yet Implemented
Screenshot of In-Progress Implementation