search

chrisglein / artificial-chat

2 stars 1 forks source link

App version doesn't display in store released builds #78

Closed chrisglein closed 1 year ago

chrisglein commented 1 year ago

Problem Description

https://github.com/chrisglein/artificial-chat/pull/74#issuecomment-1468798034

This means it doesn't show in the about dialog And it isn't passed through to the feedback submissions

Steps To Reproduce

Open about dialog see nothing

Expected Results

See app version

App version

1.0.21

chrisglein commented 1 year ago

Not sure why yet, but ReactPackageProvider::CreatePackage is not being executed in a release build but is in a debug build.

chrisglein commented 1 year ago

Noticed this is ReactPackageBuilder.cpp, which is the codepath hit for this module:

void ReactPackageBuilder::AddTurboModule(
    hstring const &moduleName,
    ReactModuleProvider const &moduleProvider) noexcept {
  if (m_isWebDebugging)
    m_modulesProvider->AddModuleProvider(moduleName, moduleProvider);
  else
    m_turboModulesProvider->AddModuleProvider(moduleName, moduleProvider, true);
}

This repros fine in debug builds if you disable web debugging. So question is why this doesn't work as a turbo module.