Closed pSpitzner closed 1 year ago
sure we can do that, thx!
next time you do a PR (not only for this project, but in general), be sure to also edit the README and to reflect the changes you made. Thanks! (I already did so for this one.)
Hi chris,
thanks for the reminder.
I anticipated some discussion before you actually merge it and was suprised this happened so quick!
Thanks for the quick merge! Paul
Nah, for small changes like this one, there is no need for a bigger discussion. All changes are contained to an independent "module" of the workflow, and existing users with an existing pdf-folder are not affected anyway.
So the change is self-contained and does not affect the development side and the user side really, so it's not a big deal in this case.
Just a suggestion: If the PDF_FOLDER is not specified, instead we can check if the bibtex library has the
file = {}
line and open the files from there.Motivation is that I use zotero (with webdav syncing) and Zotfile, so I do not want to move the pdfs elsewhere. However, since the file-path can be included in the library export, we can simply hijack it as a fallback.