search

christiaanderidder / QuestPDF.Markdown

QuestPDF.Markdown allows rendering markdown into a QuestPDF document
MIT License
26 stars 5 forks source link

Add base64 option for images #72

Closed JeroenVerseput closed 1 month ago

JeroenVerseput commented 1 month ago

I noticed that adding base64 encoded images did not work in my markdown too PDF conversion. After some research i discovered that the current version of QuestPDF.Markdown did not support base64 encoded images. In this pullrequest I added this functionality.

I hope this could be an addition too this solution. If there are any remarks, please let me know :)

christiaanderidder commented 1 month ago

Hi @JeroenVerseput,

The change looks good to me, just one small remark: You have added the base64 image to the test.md file, but it's still missing in the code block below the image showing the source code, if you add it there I'll merge the PR.

christiaanderidder commented 1 month ago

Closing in favor of #73