search

christopher-l / space-bar

GNOME Shell extension that shows workspaces buttons in top panel
178 stars 13 forks source link

added setting to disable overview toggle on current workspace. #12

Closed ElasticDuckCode closed 1 year ago

ElasticDuckCode commented 1 year ago

What has been introduced

Hello, I've have implemented an additional setting to Space Bar which allows for the disabling of the overview toggle when clicking on the current workspace.

The new setting overview-on-current-workspace has been introduced to the behaviors tab, and has been set to true by default to maintain the original behavior of the extension.

I believe this setting is desirable for people like me who like to switch workspaces quickly using the keyboard shortcuts Super+1 ... 0, and generally never use the Gnome overview.

The problem this solves.

A problem that used to occur using Space Bar is when I would switch workspaces quickly, I would often accidentally hit the number corresponding to the current workspace on the keyboard before switching to the desired workspace. As a result, when I got to my desired workspace, I would be in overview mode, and then have to press Esc in order to exit overview mode. While this isn't a show stopper, it can get very annoying when having to switch between very close workspaces (e.g. cycling between workspaces 1,2,3).

How this solves the problem

With this new overview-on-current-workspace setting, I can disable the overview toggling behavior. This solves the above problem as I can then quickly switch to any workspace I want without ever accidentally bringing up the overview.

Please let me know if you see any needed additions I missed in the changes below.

christopher-l commented 1 year ago

Hey, thanks for your contribution!

My first impulse is to combine the option with overview-on-empty-workspace (see appended commit). Does this work for you?

ElasticDuckCode commented 1 year ago

Yes! I do believe this is actually the desired functionality.

This works for my use case, because when combined with the pop-shell extension, I basically never want to toggle the overview, whether it be an empty workspace or the active workspace.

Thank you!