Doesn't work with touch displays

christopher-l / space-bar

GNOME Shell extension that shows workspaces buttons in top panel

178 stars 13 forks source link

Doesn't work with touch displays #30

Closed lukgreen closed 7 months ago

lukgreen commented 10 months ago

Clicking on workspace numbers or names on a touch display doesn't work.

christopher-l commented 10 months ago

Hi @lukgreen, thanks for the report!

I tried to add support for touch events, but I don't own a touchscreen device. Could you test the following features:

Single tap should switch to the workspace as a left click does.
Long press should open the menu.

I didn't write any code to support drag-and-drop. Could you also check, if this interferes in any way?

To install the updated version, download https://github.com/christopher-l/space-bar/raw/feat/touch-events/space-bar@luchrioh.shell-extension.zip and run the following command inside the containing directory:

gnome-extensions install --force space-bar@luchrioh.shell-extension.zip

Thanks for your help!

lukgreen commented 10 months ago

Single tap and long press work as intended.

Drag and drop though works oddly. In the end of the drag operation, before unpressing the screen, the menu opens. If I touch somewhere on the screen the menu disappears and reordering doesn't happen. The menu itself is not usable. At an attempt to name a workspace it closes.

My old laptop now works almost better than any android device from UX perspective! Thanks!

christopher-l commented 8 months ago

Thanks for testing and sorry for the long pause.

I updated the link to the zip file above to contain what is hopefully a fix for the drag-and-drop behavior. Could you do another check?

lukgreen commented 7 months ago

It works.

christopher-l commented 7 months ago

Thanks for testing! Merged and submitted to extensions.gnome.org. Note that touch support is introduced with the newest version of the extension (25), which is only compatible to GNOME 46.