search

christopher-l / space-bar

GNOME Shell extension that shows workspaces buttons in top panel
178 stars 13 forks source link

Support for Gnome 46 #35

Closed nightsh closed 7 months ago

nightsh commented 8 months ago

Hi and thanks for the great work you're doing :-) I've been using this extension until yesterday, when Gnome 46 became available in Tumbleweed repos. Now I'm getting the "incompatible" message:

image

I'm not sure if compatibility is limited by just a version number, or there are other breaking changes in the 46 release, but I'd be happy to try it out, if you would lay out some steps for me to follow.

Thanks!

maxgreene123 commented 8 months ago

If you compile from source and change the gnome version from 45 to 46 in the metadata.json and install it works perfectly.

akhilesh-w commented 8 months ago

@maxgreene123 so can you not just make a pull request with this change so that everybody can use it?

maxgreene123 commented 8 months ago

Oh yeah your right lol. I just opened the pull request with the update for gnome 46.

akhilesh-w commented 8 months ago

@christopher-l can you check the pr?

christopher-l commented 8 months ago

Accepted the PR, thank you!

I'm AFK for some days, will submit the updated extension when back.

yochananmarqos commented 8 months ago

@christopher-l I think you forgot to bump Mutter, etc. from 13 to 14 in the build.sh package.json. :wink:

christopher-l commented 8 months ago

@yochananmarqos The build:types script in the package.json?

yochananmarqos commented 8 months ago

@christopher-l Oh yes, sorry. :laughing:

christopher-l commented 7 months ago

Updated the types and submitted to extensions.gnome.org.

I ended up removing support for GNOME 45 again since the type updates indicated some breaking changes that I had to adapt to.