swagger integation - Githubissues

christophknabe / spring-ddd-bank

A sample project following Domain Driven Design with Spring Data JPA

GNU Lesser General Public License v2.1

509 stars 125 forks source link

swagger integation #9

Closed thomaskos closed 6 years ago

thomaskos commented 6 years ago

I'd like to resolve #4

Added swagger to the project for all API operations prefixed by /bank/ and /client/ in ApplicationController
Additional WebSecurityConfig settings for swagger-ui
Unfortunately sagger-ui does not permit empty passwords. Therefore passwords for predefined users now match usernames.

christophknabe commented 6 years ago

Thank you very much for your pull request. I already tried this some time in a private branch, but did not yet succeed. The file differences look good, but I am now in examination phase, so I now don't have the time for testing your PR. But surely after some weeks. One question: Is the additional repository jcenter-snapshots in the POM really necessary? Because the required swagger versions are no snapshot versions.

thomaskos commented 6 years ago

Thanks for your quick reply. You are perfectly right about the unnecessary snapshot repository. I've just removed it.

christophknabe commented 6 years ago

Thank you very much for doing this. I tested and I am really satisfied about the result. This was a very constructive pull request.