search

chriswill / DbUpReboot

Library to help update SQL databases to keep them up to in sync with software requirements.
Apache License 2.0
13 stars 5 forks source link

Azure SQL - Service Objective #10

Open LordBenjamin opened 5 months ago

LordBenjamin commented 5 months ago

DbUp currently allows the caller to specify an AzureDatabaseEdition.

Ideally, it would be good to allow finer control over this by accepting a parameter specifying the Service Objective (e.g. S0, etc).

At it's simplest, this could be an optional string argument passed to SqlDatabase() - alternatively, an enum similar to AzureDatabaseEdition might be a better DX (although would probably add maintenance overhead if MS changes SKUs).

This would ultimately mean that the DbUp command would change from:

create database [mydatabase] ( EDITION = 'standard' );

to:

create database [mydatabase] ( EDITION = 'standard', SERVICE_OBJECTIVE = 'S0' );

when a service objective parameter is supplied.

I am happy to raise a PR for this, but wanted to gauge interest / opinions first.

chriswill commented 5 months ago

Sure, this sounds like a nice addition. Please send along a PR and thanks for suggesting.

I built this fork because the original DbUp project wasn't evolving fast enough. I definitely want this to be a community-driven project to meet the needs we have.