search

chylex / Minecraft-Window-Title

Minecraft mod that lets you customize window title and icon.
https://www.curseforge.com/minecraft/mc-mods/custom-window-title
The Unlicense
8 stars 2 forks source link

Reimplemented Icon Support. #14

Open Kolotheegg opened 1 month ago

Kolotheegg commented 1 month ago

Reimplemented Icon Support.

Used Lambda functions for config reading.

You now only need to provide one Icon and the Pixel Width and Height no longer matters, for a clean look I suggest using a square icon.

chylex commented 1 month ago

Thanks, I'll take a look when I have time, can't guarantee when that will be.

Kolotheegg commented 1 month ago

Is there an issue with the code or did you just not have time yet?

chylex commented 1 month ago

I haven't had time for Minecraft, and will not have time for at least 2 more weeks.

Kolotheegg commented 3 weeks ago

I will implement the requested changes when I have time. I'm on vacation for 2 more weeks.

Kolotheegg commented 3 weeks ago

What autoformatter are you using?

chylex commented 3 weeks ago

I use IntelliJ but I didn't commit the code style settings.

Kolotheegg commented 4 days ago

Is there any further issue with my implementation?