search

chzesa / tiled-tab-groups

27 stars 6 forks source link

Feature Request: Add "Bookmark Group" option to Tab Management Page (also, minor bug report regarding bookmarks). #35

Open MintMain21 opened 2 years ago

MintMain21 commented 2 years ago

Title says it all. Add an option, either to the top of a Group column or to the context menu, to bookmark an entire group instead of having to manually select every tab in the group and then bookmark them all (alternatively, add a context menu option to select all tabs in a group, and then allow us to bookmark the tabs).

On a related note, there's a minor bug wherein tabs cannot be bookmarked from the Tab Management Page. When I use this context-menu option on the Tab Bar, a little pop-up appears that allows me to edit the bookmark, including it's name and location This pop-up will not appear when doing this same action from the Tab Group Management Page, rendering the option useless.

chzesa commented 2 years ago

The extension apparently lacks the bookmarks permission so creating bookmarks through it is simply impossible right now.

I'm planning to overhaul the management view to allow more actions to be added for groups, bookmarking the group can be one of them.

MintMain21 commented 2 years ago

Just got today's update, and... I guess the bug is technically fixed cause I can bookmark tabs from the Tab Management Page, but there's still no dialogue box pop-up like when bookmarking from the Tab Bar, and therefore no way to chose where or how bookmarks are saved. They'll always default to the Other Bookmarks folder. Not a terrible compromise, I suppose, but far from ideal. I tried using another extensions to cheese the system (Tab Stash), but via that method I only have the option to stash individual tabs at a time (which is doable) or (ironically enough) stash all but the currently un-hidden tabs at once (IE: The current Tab Group).

I can only presume this is the beginning of a lengthy improvement process. Your promise to "overhaul the management view" sounds exciting, but all I really need is a bookmarking dialogue like in the tab bar. (btw, I figured out how to select an entire tab group at once, and thus how to bookmark an entire tab group at once, so I don't need any drastic UI update anyway).

PS: Thanks for the swift reply and update.

chzesa commented 2 years ago

As far as I can tell, it's not possible for an extension to make use of the native bookmarking dialog so I would have to make a replacement for it from scratch. This isn't to say I won't implement something similar, but I cannot implement it so quickly whereas fixing the bookmark permission was trivial.