cinatic / stocks-extension

A extension to display stock quotes in GNOME Shell Panel
GNU General Public License v3.0
84 stars 31 forks source link

V20 Settings not compatible with gnome-shell < 42 #71

Open brunkenj opened 1 year ago

brunkenj commented 1 year ago

This is seen on Fedora 35 with all available updates, Gnome 41.6, and version 20 of the extension. Version 20 appears to be the latest version of the extension that is compatible with Gnome 41.6.

The following exception is thrown when the gear icon is selected. Gnome opens up a window with an error notification and the following text in the Technical Details box:

Error: Requiring Adw, version none: Typelib file for namespace 'Adw' (any version) not found

Stack trace: @/home/user/.local/share/gnome-shell/extensions/stocks@infinicode.de/components/settings/aboutPage.js:4:53 @/home/user/.local/share/gnome-shell/extensions/stocks@infinicode.de/prefs.js:6:23 _init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:216:33 OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:128:33 asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:115:22 run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20 main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13 run@resource:///org/gnome/gjs/modules/script/package.js:206:19 start@resource:///org/gnome/gjs/modules/script/package.js:190:8 @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

brunkenj commented 1 year ago

To be clear, this is not the same type of failure as reported in issue #69.

cinatic commented 1 year ago

yes i mixed up the compat list in EGO, so you probably always fall back to v20 which of course will not work. Not sure actually how to fix this, please use v19 or whatever version is working with 41

brunkenj commented 1 year ago

Going back to v19 did solve the problem. I edited metadata.json to add "41" to the shell-version field.

Should this issue be left open?

cinatic commented 1 year ago

yes let's keep it open and thanks for the report