I needed to change the quote colours (especially in menuStockTicker, but I've covered all other places).
QuoteStyleSettings is responsible for the font and colour
a new page in the extension settings Styles
getStockColorStyleClass was replaced with getQuoteStyle
I was thinking about moving the first three settings from Settings to that new page Styles as they are relative, but I decided not to touch existing features.
Please let me know if I overlooked something, as it was my first experience with Gnome Shell Extensions :)
Hi @cinatic !
I needed to change the quote colours (especially in
menuStockTicker
, but I've covered all other places).QuoteStyleSettings
is responsible for the font and colourStyles
getStockColorStyleClass
was replaced withgetQuoteStyle
I was thinking about moving the first three settings from
Settings
to that new pageStyles
as they are relative, but I decided not to touch existing features.Please let me know if I overlooked something, as it was my first experience with Gnome Shell Extensions :)
PS. This PR will also be a proper fix for the https://github.com/cinatic/stocks-extension/issues/62 and https://github.com/cinatic/stocks-extension/issues/45 issues.
Screenshots
Styles settings page
Overview
Details positive
Details negative
Compact
Regular
Tremendous
Minimal