search

cinatic / stocks-extension

A extension to display stock quotes in GNOME Shell Panel
GNU General Public License v3.0
85 stars 31 forks source link

Backport yahoo patch v24.1 #91

Closed stieg closed 1 year ago

stieg commented 1 year ago

Ports the Yahoo fix back to v24 of extension so users of Gnome Shell v42 (Ubuntu 22.04 LTS) can have this extension work for them.

@cinatic Suggest you create a v24 branch on your repo and I can target that for this merge if you like. Or just merge this in as you see fit. I based this commit off of v22 since that was the closest one I could base it off of. There are really only 2 commits here, the cherry-pick and the version bump commit. LMK how you want to proceed.

stieg commented 1 year ago

bump

cinatic commented 1 year ago

hey, thanks for your effort. At the first glance this looks very good, I would like to run it on some test distros, then I will merge it (not sure about the name yet)

cinatic commented 1 year ago

release has been created https://github.com/cinatic/stocks-extension/releases/tag/v24.1

LaurentChardon commented 1 year ago

I didn't see that @stieg had submitted this PR, so I replicated the work today (except that I started from v24.1 instead of v22). It's not all wasted, I learned some things. @cinatic, the fact that I was able to start from v24.1 shows that there is a problem with that tag. It doesn't have the changes from v24_fixed_yahoo_api in it. It looks like the tag was made from v20.