cisagov / con-pca-api

API Docker Container for Con-PCA
Creative Commons Zero v1.0 Universal
7 stars 0 forks source link

Feature CPD-904: Include cycle_id in download file name #722

Closed izzy64 closed 2 years ago

izzy64 commented 2 years ago

๐Ÿ—ฃ Description

Jira ticket: https://cset.atlassian.net/browse/CPD-904

Frontend changes: https://github.com/cisagov/con-pca-web/pull/387

Added cycle_id to the filename string when downloaded.

Added an optional argument so that cycle_id can be passed to the Email() function and then added to the filename string when reports are emailed.

๐Ÿ’ญ Motivation and context

Sometimes one wants to pull down and compare multiple cycle reports from the same subscription. If the reports have the exact same name, this is very inconvenient.

๐Ÿงช Testing

Please double check this one

โœ… Pre-approval checklist

โœ… Pre-merge checklist

โœ… Post-merge checklist