Fix https://github.com/cisagov/con-pca-api/pull/830: Cover the Case of no qualifying groups - Githubissues

cisagov / con-pca-api

API Docker Container for Con-PCA

Creative Commons Zero v1.0 Universal

7 stars 0 forks source link

Fix https://github.com/cisagov/con-pca-api/pull/830: Cover the Case of no qualifying groups #831

Closed izzy64 closed 1 year ago

izzy64 commented 1 year ago

🗣 Description

Previous PR: https://github.com/cisagov/con-pca-api/pull/830

Added logic to cover the edge case of when no groups have more than 5 participants.

💭 Motivation and context

Testing revealed that the previous feature was causing cycle reports to fail if there were no qualifying groups.

🧪 Testing

Tested locally.

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.