Closed izzy64 closed 1 year ago
This pull request introduces 1 alert when merging 9c24b45434f1222fa3817db34151f9b6a1411ff8 into 85e3bdb7311b5b45132837832520d6985a7bfc90 - view on LGTM.com
new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down โป completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.
๐ฃ Description
๐ญ Motivation and context
If populate_cycle_stats doesn't work due to timeout error
[2022-11-17 03:12:03 +0000] [11] [CRITICAL] WORKER TIMEOUT (pid:27)
then no tasks will run because part of CPD-1031 was moving task processing to be done off of the cycle, rather than the subscription. This PR reverts those changes, having the tasks_job check the subscriptions once again until we can be sure that the migration of tasks data from the subscriptions to the cycles was successful.๐งช Testing
โ Pre-approval checklist
[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests pass.