search

cisco-sbg-ui / magna-react

magna-react.vercel.app
5 stars 0 forks source link

AButtonGroup should support medium prop #155

Closed keweeks closed 1 year ago

keweeks commented 1 year ago

Looking at: https://magna-react.vercel.app/components/button-group I notice that there is no support for the medium prop like buttons allow.

It seems like this should be supported to maintain a consistent height with buttons/button groups

rwharrisjr commented 1 year ago

This can be accomplished now by adding medium to each button. Added an example to the button group page.

Screenshot 2023-02-07 at 4 23 20 PM

https://github.com/cisco-sbg-ui/magna-react/pull/156 Adds a medium prop to AButtonGroup for a less verbose syntax.

keweeks commented 1 year ago

🤦‍♂️