search

cisco-sbg-ui / magna-react

magna-react.vercel.app
5 stars 0 forks source link

ADivider is 2px but probably should be 1px #323

Closed mvelkCisco closed 9 months ago

mvelkCisco commented 1 year ago

We came across this in https://github.com/cisco-sbg-ui/magna-react/pull/322#discussion_r1147479570

The magna-react docs show ADivider used in the menu, so that's what products are doing (eg incident-manager). However based on figma the divider in menus should be 1px not 2px (incident-manager adds a global override to make all divides 1px).

I don't think a divider exists in magnetic, or I could not find it at least. All the separators I've seen on magnetic are 1px. This doesn't look right:

image

I would propose to just change it in magna-react to 1px.

mvelkCisco commented 1 year ago

Alternatively we can override only when used in the menu.

androche commented 9 months ago

Closing as this has been resolved further in: https://github.com/cisco-sbg-ui/magna-react/pull/587