cisco-sbg-ui / magna-react

magna-react.vercel.app
5 stars 0 forks source link

Tertiary button hover state does not follow Magnetic specs #355

Closed vdineva closed 1 year ago

vdineva commented 1 year ago

I may be looking at the wrong places but is seems the padding around a tertiary button in magna-react is not following the specs from Magnetic:

Screenshot 2023-04-24 at 12 18 35 Screenshot 2023-04-24 at 12 18 29

References: https://www.figma.com/file/yU3qYkj6T2kfN4XYtUkEeD/Dark-Mode-%5BWiP%5D?node-id=33305-358611&t=11tCf4YYljxx4HBK-4 and https://magnetic.cisco.com/0a43ab5cd/p/56608b-button

and in Magna-react we currently have:

Screenshot 2023-04-24 at 12 19 08 Screenshot 2023-04-24 at 12 19 03

https://magna-react.vercel.app/components/button

androche commented 1 year ago

Follow up, we heard from magnetic that the design may be changing so we've decided to leave as is for now! Reference below:

Screenshot 2023-05-04 at 12 17 10 PM