search

cisco-sbg-ui / magna-react

magna-react.vercel.app
5 stars 0 forks source link

Convert ADropdown to use AFloatingMenu #918

Closed rwharrisjr closed 1 month ago

rwharrisjr commented 1 month ago

Additionally adds ability to set component of either ATag or AButton Extends ATag to handle a dropwdown variant

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
magna-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 7:24pm
androche commented 1 month ago

Cool although with this approach can the tags still be different colors and variations? I'm wondering if it makes more sense to fix up the tag itself? Screenshot 2024-10-15 at 2 23 45 PM

rwharrisjr commented 1 month ago

@androche maybe if we added in a componentProps prop? Either that or we can split it out into ATagDropdown, but that seems excessive