make schedule section

[nibchao]

• I'm not sure how to make the columns (Events/Workshops/Activities) as wide as they appear on the CutieHack page.
• I don't know how to make the descriptor text for each schedule item fit on a single line rather than continuing onto another line.
• Also I am not sure which <h#> to use and whether I should be using <p> instead of <div> for some of the elements.

[andreidimaano]

Can you upload a screenshot of what it looks like

[minsooerickim]

10

[nibchao]

Can you upload a screenshot of what it looks like

this is how it looks at the moment before making any changes to my code

[minsooerickim]

@nibchao for future reference, reply to the comments made by the reviewers so they know you've pushed up changes and they can review again

[nibchao]

@minsooerickim sorry, i'm not familiar with pull requests and didn't know my commits would show up and/or notify participants(?), so i always committed/pushed immediately even with code that doesn't work. is it correct to continually make commits on vs code until i have working code then do a single push when it's ready for review?

[minsooerickim]

correct to continually make commits on vs code until i have working code then do

no need to apologize ahah. I don't think there is a set rule you need to follow but this is the general workflow I follow

1. make changes on vscode
2. commit as much as I can with useful commit messages
3. then once a section of a code is working (the whole thing doesn't have to be ready) or I decide I want to stop working for the day, I push it up to github even if it has broken code
4. then once I think the code is ready for review (my code addresses the issue), I open a pull request so people can review my code

After the pull request is open and people make comments, the changes are usually small so I address most of the changes in one or two commits then push it up. Once the PR (pull request) is open, I generally don't push up broken code.

Workflow is something you learn as you go so don't be afraid to make mistakes!! and let me know if you have any other questions

[andreidimaano]

@minsooerickim sorry, i'm not familiar with pull requests and didn't know my commits would show up and/or notify participants(?), so i always committed/pushed immediately even with code that doesn't work. is it correct to continually make commits on vs code until i have working code then do a single push when it's ready for review?

do a lot of commits and then make one PR, if you're code doesn't work and you are having issues unblocking yourself, ask in the discord channel and I can help :D

[nibchao]

here's a new screenshot of how the schedule page looks after all the changes. thank you andrei for breaking down all the changes that needed to be made and minsoo for explaining workflow for pr's!

[minsooerickim]

remove ur yarn.lock file, idk where u got those changes but it doesn't look like ur using any new packages

[minsooerickim]

nice work btw, sry if my comments sound a bit harsh; I'm not trying to be mean lol it just takes too much time to write out nice sentences

[vercel[bot]]

@nibchao is attempting to deploy a commit to the cutiehack2022 Team on Vercel.

A member of the Team first needs to authorize it.

[minsooerickim]

for yarn.lock, you can just delete the file and push up the deleted change, no need to copy paste anything. Once you do that, you should see no yarn.lock file under 'changes' tab on github

[minsooerickim]

make sure you @ whoever left comments after u address their comments, so they can come check ur updated changes, then they can resolve their threads :)

[nibchao]

@minsooerickim did i address all of your comments with the changes/commits i've done? i deleted yarn.lock in both my schedule-section and support-section branches, but it seems deleting it for only schedule-section branch causes issues?

[minsooerickim]

@minsooerickim did i address all of your comments with the changes/commits i've done? i deleted yarn.lock in both my schedule-section and support-section branches, but it seems deleting it for only schedule-section branch causes issues?

same comment as my latest comment here. just don't commit the deleted yarn.lock changes

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
cutiehack2022	❌ Failed (Inspect)		Sep 26, 2022 at 3:26AM (UTC)

[nibchao]

@minsooerickim i did the same thing with the yarn.lock file in this branch as i did in the support section branch and now the deleted LOC is this instead of the -3k it was earlier