citrushack / cutiehack2022

Codebase for CutieHack 2022. 600+ Users
https://cutiehack2022-cutiehack2022.vercel.app/
0 stars 20 forks source link

add basic format for staff component #38

Closed pondohoo closed 2 years ago

pondohoo commented 2 years ago

I'm kind of learning as I go so I'm just trying an approach I thought might work. Let me know about any optimizations or issues.

Side note, my understanding is that to import an image into the Nextjs Image component I needed to go into next.config.js and add this line

module.exports = { images: { domains: ['images.unsplash.com'], }, }

Let me know if there is a more effective way to do that

pondohoo commented 2 years ago

also, this is what the component looks like when I tested it

Screen Shot 2022-08-01 at 10 29 41 Screen Shot 2022-08-01 at 10 29 14
minsooerickim commented 2 years ago

@pondohoo you should move Staff.tsx under pages/sections (i think you have to create a folder)

pondohoo commented 2 years ago

@pondohoo you should move Staff.tsx under pages/sections (i think you have to create a folder)

oh okok I was just kind of following the file structure of the FAQ component

vercel[bot] commented 2 years ago

@pondohoo is attempting to deploy a commit to the cutiehack2022 Team on Vercel.

A member of the Team first needs to authorize it.

pondohoo commented 2 years ago

@minsooerickim I figured out how to make two columns show up on smaller screens! Lmk if I missed anything. Also I'm not sure what Vercel is and if I did something that messed that up?

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cutiehack2022 ✅ Ready (Inspect) Visit Preview Aug 15, 2022 at 2:09AM (UTC)
minsooerickim commented 2 years ago

@minsooerickim I figured out how to make two columns show up on smaller screens! Lmk if I missed anything. Also I'm not sure what Vercel is and if I did something that messed that up?

Vercel is a tool we use to deploy our website, I added the deployment check so that we can always check if changes made to our code can be successfully deployed. It looks like there are changes you need to pull from dev. There might be some merge conflicts you need to resolve. (this can get a little confusing so lmk if you need help)

minsooerickim commented 2 years ago

@minsooerickim I figured out how to make two columns show up on smaller screens! Lmk if I missed anything. Also I'm not sure what Vercel is and if I did something that messed that up?

2 column looks good, just make sure to address all the other comments

minsooerickim commented 2 years ago

@pondohoo looks good to me! nice work

minsooerickim commented 2 years ago

closes #13