Closed atdservicebot closed 3 years ago
@frankhereford figure out if there's still an existing problem. Make comments or recommend on closing.
@patrickm02L: I recommend that this issue be closed, as I find these crashes to have the correct speed management points calculated per crash.
As an aside, for planning purposes, I would like to note that there is some discussion among the speed management team about the scoring algorithm used, so it is not impossible that we'll be revisiting speed management points in the coming weeks or months, but that is not germane to this issue.
To this issue however, I have reviewed the bulk of these crashes, and the main theme is that they have a fatality, but it is marked as a non-ATD fatality. These are fatalities which do not meet one of these criteria:
Upon consultation with @xavierapostol, he has confirmed that these non-ATD fatalities should not contribute to speed management points, which they currently do not. As things are working as expected, I believe that this issue was addressed at some point, but this issue slipped by without being closed. A mirror issue was closed in the VZ repo, as noted above.
Thanks for the comprehensive overview @frankhereford. Thanks for flagging the speed management points scoring algorithm needs to be addressed in the future.
Xavier noticed a few records not getting the correct values for “speed_mgmt_points”, this is a list of records with the reported problem:
Migrated from atd-vz-data #646