Bug on LM: Initial distribution date changes during redistribution (RB) (Deploying to PROD)

atdservicebot commented 6 months ago

Fixing a bug on the Update Distribution process to stop overriding the process dates on the Initial Distribution process.

When the user saves any attempt on the Update Distribution, the system should not update any process dates on the Initial Distribution process.

What application are you using?

AMANDA

Describe the problem.

The date for initial distribution in the Process Tab for License Agreements changes when the file is re-distributed for review. This makes it difficult to track review cycles. Tracy Linder is aware and can give more details.

Is there anything else we should know?

please loop in Tracy Linder, Beth Robinson and Kathy Uhrig

Internet Browser: Chrome

Requested By Gilbert M.

Request ID: DTS24-114320

TracyLinder commented 6 months ago

Next Steps:

Schedule time with Kathy to watch her reproduce this issue and identify what is supposed to be happening vs what is happening.
Kathy may try doing a screen recording to show us the issue; perhaps we won't need to meet.

TracyLinder commented 6 months ago

Kathy's screen recording

TracyLinder commented 6 months ago

DTS-AMANDA Refinement Conversation 5/14/24

This appears to be caused by saving the 'complete' attempt on process 'Update Distribution'
Update Distribution is added manually by the user. Why? Was it coded to update the initial distribution start date for a specific business need? Are we going to break that?

TracyLinder commented 6 months ago

Scoping meeting with Kathy & Vish scheduled for 5/28

TracyLinder commented 5 months ago

Discovery with Kathy 5/30/24

The review distribution should always be based on the review distribution infos on info tab

Review Process:

Web Application Acceptance
Initial Distribution; Complete (sends everyone emails, inserts all reviews, updates folder status to In Review)
User manually inserts process 'Update Distribution' and saves 'Complete' attempt. (System inserts reviews based on info tab, updates folder status to In Review, sends emails, ❌updates date on Initial Distribution Process ❌)

Review timelines: Initial distribution = 14 business days Subsequent distribution = 7 business days

Tasks:

[ ] Assign DEV to document how the folder processes are configured per subtype. Are there any differences?

Future State:

Web Application Acceptance
Initial Distribution; Complete (sends everyone emails, inserts all reviews, updates folder status to In Review, inserts Update Distribution attempt)
Update Distribution; 'Complete' attempt. (System inserts reviews based on info tab, updates folder status to In Review, sends emails)

TracyLinder commented 5 months ago

@rajeshlaunch can you please do an analysis on this request as we discussed? Please determine if the folder processes are determined by folder subtype.

rajeshlaunch commented 5 months ago

@TracyLinder Analysis and findings:

ScheduledEndDate and ScheduleDate for all the process are updated due to the condition in the query that is trying to update the date for the processes that are available for the particular folder. It is not looking for any processcode or process status to update these dates.
Processes are inserted through package function and it gets the list of process to be inserted from the lookup (Code: 50140).

Solution:

Need to update the ScheduleEndDate and ScheduleDate for the processes that are part of the review process group and with process status as "Open". By doing this only the processes that are open and part of review process group will be updated and not all the processes in the folder.

TracyLinder commented 4 months ago

Outstanding Questions:

We still need to know if this should apply to all LM subtypes.
When Update Distribution is inserted, who should be assigned and what process dates should be inserted?

TracyLinder commented 4 months ago

I meeting with Kathy on Friday to go over the remaining questions.

TracyLinder commented 3 months ago

Conversation with Kathy

LDE staff is manually inserting the Initial Distribution process also.

Outcome

The LM distribution processes as a whole need to be analyzed and updated, similar to what we did with the UC distribution. I will create a different ticket for that work, and this ticket will focus only on correcting the date bug that was reported.

Nadin-Nader commented 3 months ago

This has been sent to the DevOps CM Team to be deployed to DEV under SCTASK0444721

Nadin-Nader commented 3 months ago

Sent an email to CTM to revert the commit as the procedures in DEV have a different name and must be matched. Waiting on CTM

Nadin-Nader commented 3 months ago

This has been sent to the DevOps CM Team to be deployed to DEV under SCTASK0446506

Nadin-Nader commented 2 months ago

@rajeshlaunch this is ready for UAT on DEV

TracyLinder commented 2 months ago

Per Nate, this is ready for UAT on test.

Nadin-Nader commented 1 month ago

This ha sbeen sent to the DevOps CM Team to be deployed to TEST under SCTASK0463186

Nadin-Nader commented 4 weeks ago

@rajeshlaunch this is ready for your UAT on TEST

rajeshlaunch commented 3 weeks ago

@Nadin-Nader I have verified the changes and it is working as expected. User can test this fix in TEST.

UhrigK commented 3 weeks ago

@Nadin-Nader This is working as it should.

Nadin-Nader commented 3 weeks ago

@rajeshlaunch this has been approved by Kathy to go to PROD.

rajeshlaunch commented 2 weeks ago

Production deployment plan submitted.

Nadin-Nader commented 2 weeks ago

This has been sent to the DevOps CM Team to be deployed to PROD under SCTASK0467535

cityofaustin / atd-data-tech