Open patrickm02L opened 4 months ago
@dianamartin @ChrispinP to do some background work to get the Apps requirements documented.
scene_231
scene_78
Invoice X | Details Page | # of Impoundments | Invoice # |
---|---|---|---|
INVOICE ABC | |||
X | INVOICE ABC Details | Provider Impoundments | INVOICE ABC |
Provider Impoundments> | INVOICE ABC | ||
Provider Impoundments> | INVOICE ABC |
Invoice X | # of Impoundments | Invoice # |
---|---|---|
INVOICE ABC | ||
Provider Impoundments | INVOICE ABC | |
Provider Impoundments> | INVOICE ABC | |
Provider Impoundments> | INVOICE ABC |
Impoundment Fee
She said the influx of impoundments can come from Parking Enterprise leadership or higher up the chain (City Manager), so not sure how many there will be per Provider in the future.
We also discussed that we're leaning toward "Option 1".
// Set scenes and views
var scene = "scene_4";
// Items table
var itemsView = "view_60";
var itemsEditableView = "view_16";
// Invoice Items table
var invoiceItemsAdminView = "view_681";
var invoiceItemsNonAdminView = "view_717";
// Invoices table
var invoicesView = "view_282";
Added to the "Invoice Details" (in PROD)
Messaged Andrea
Hey, just FYI.. I added the "impoundments" table on the Invoice Details page until we can get the enhancement updated (See Bird Example) here
You'll be able to click into the highlighted area and associate an impound to an invoice
Provider Impoundments
table so that staff can choose which of the unpaid impoundments will be added to the invoice.I created a new Invoice and two test records for Bird for testing.
When trying to add impoundments, I was able to select them but when I pushed the button it didn't trigger an association.
https://github.com/user-attachments/assets/f3d88de9-88a8-40cd-a428-38a37fa8d43e
Chia let me know that when cleaning up the code yesterday she forgot to clean up one part and introduced a bug. And all let me know that when the impoundment gets assigned it would dissapear from the table because it was filtered to show records without an invoice
Now I could select the record and when pushing the Add selected to invoice
button they dissapeared after I refreshed the page.
https://github.com/user-attachments/assets/18371985-1754-48f9-974f-ae77e5ed194e
Chia recognized that she only refreshed the bottom view, and made it to where both views were refreshed.
Realized that the impoundments showed up in the impoundments table and had the correct invoice associated with them. Also, realized that I had to Add invoice items
manually to get them to show up in the Invoice Details page and subsequent PDF.
https://github.com/user-attachments/assets/8cb9cc8c-f884-42cc-a1d0-21edb0d9ed85
Everything worked as expected.
Good to Go! 🚀
Diana, Chia, and I met to discuss the functionality of the multi-select impoundments. The goal of the impoundments is make them selectable and move them from the "Provide Impoundments" table to the "Invoice Items" table.
Test app ready for re-review
Patrick brought up question of deleting Invoice Items, and if anything should happen when invoice items are removed.
@chiaberry
impoundment
-
343: Lime, 01/02/2024 - 2 - $200
{Impoundment No}: {Provider Name}, {Date of Impound} - {Number of Units} - {Impound Fee}
(you can reference the impoundment
Object table)Transaction Status
- should be set to "UNPAID" (by default)I'll added two invoice items to compare on this invoice: INV24-000782
TXN24-003775
- is a manually entered one by a TPW SMS Staff
You'll notice this record has the
impoundment
connection associated to it
TXN24-003955
- was added using the "Add to invoice items" button
You'll notice this record doesn't have the
impoundment
connection associated to it
To review records on the back end go to the "Invoice _item" table
@dianamartin please make sure to add the trigger to clear out the Invoice ID if it's removed from the Invoice Items table, and can be found in the Provider table.
I opened this PR, the code is in the test app: https://github.com/cityofaustin/atd-knack/pull/161
I have checked to make sure the fields have the same ids in prod, so in theory nothing should need to be updated when moving it to the SMRT prod app.
If you need any dev assistance while I'm ooo, devs can help triage.
@patrickm02L
Remove connection
. It should blank out the invoice connection.
Description
Currently when creating an invoice, impoundments can only be associated one at a time. Implement a feature that allows selecting multiple impoundments from a list and associating them all at once with an invoice.
Acceptance Criteria
Notes
We've implemented a similar process for the finance app.
Issues
Code
Prototype