[Feature] Allow selecting multiple impoundments to associate with invoices

[patrickm02L]

Description

Currently when creating an invoice, impoundments can only be associated one at a time. Implement a feature that allows selecting multiple impoundments from a list and associating them all at once with an invoice.

Acceptance Criteria

• On the invoice creation page, show a list of all unpaid impoundments
• Add a checkbox next to each impoundment to select multiple
• Show the selected impoundments added to the invoice items

Notes

We've implemented a similar process for the finance app.

Issues

• https://github.com/cityofaustin/atd-data-tech/issues/1100
• https://github.com/cityofaustin/atd-knack/pull/2

Code

• https://github.com/cityofaustin/atd-knack/pull/2/files

Prototype

• Knack App

[patrickm02L]

5/8/24

@dianamartin @ChrispinP to do some background work to get the Apps requirements documented.

[dianamartin]

5/15/2024

• Chrispin and I sync on the Finance and Purchasing Code

SMRT Application

• Invoice Details page - scene_231
• Impoundments page - scene_78

Option 1:

• [ ] Create new Invoice Details page from Invoices table page
• [ ] Add "Impoundments table" to page
• Multi-selecting the impoundments and then associating them to the invoice ID that is associated (Invoice Details - currently viewing)

Invoice X	Details Page	# of Impoundments	Invoice #
INVOICE ABC
X	INVOICE ABC Details	Provider Impoundments	INVOICE ABC
		Provider Impoundments>	INVOICE ABC
		Provider Impoundments>	INVOICE ABC

Option 2:

• [ ] Add "Impoundments table" on Invoices table page and put the process of
• Selecting existing invoice and multi-selecting the impoundments that needs to be associated

Invoice X	# of Impoundments	Invoice #
INVOICE ABC
	Provider Impoundments	INVOICE ABC
	Provider Impoundments>	INVOICE ABC
	Provider Impoundments>	INVOICE ABC

• Synced with Andrea to see what their process is for creating impoundments and invoices

Impoundment Creation

• impoundment comes in
• Go to "Fees/Payments"
• Click "Add Impoundments" (SMS Staff)

Invoice Creation

• At the end of the month
• Go to "Provider>Details>Invoice>Invoice Details"
• Click "Add Invoice Item"
• Select "Transaction Type" - Impoundment Fee
• Select Impoundment record
• Add new line item for each impoundment

She said the influx of impoundments can come from Parking Enterprise leadership or higher up the chain (City Manager), so not sure how many there will be per Provider in the future.

• This came from my comment of saying there didn't seem to be that many.
• It might also be due to the throttling of 311 App records any one person can make, it's now limited to 50

We also discussed that we're leaning toward "Option 1".

// Set scenes and views
var scene = "scene_4";

// Items table
var itemsView = "view_60";
var itemsEditableView = "view_16";

// Invoice Items table
var invoiceItemsAdminView = "view_681";
var invoiceItemsNonAdminView = "view_717";

// Invoices table
var invoicesView = "view_282";

[dianamartin]

5/15/2024

Added to the "Invoice Details" (in PROD)

• [x] Impoundments associated to Provider
• [x] Added "yellow" highlight for "editable fields"
• [x] Added record rules to capture Modified Date/By fields

Messaged Andrea

Hey, just FYI.. I added the "impoundments" table on the Invoice Details page until we can get the enhancement updated (See Bird Example) here

You'll be able to click into the highlighted area and associate an impound to an invoice

[patrickm02L]

6/12/24 Dev + Product Sync

• Diana walked through the Invoice options, we're leaning toward the first solution of adding checkboxes to the on the Provider Impoundments table so that staff can choose which of the unpaid impoundments will be added to the invoice.
• Diana's making a test environment for the Devs to start building
• Chia's going to do some initial investigation this sprint with the plan to pull On Deck officially on the 6/26 sprint cycle

[patrickm02L]

7/12/24 Testing

I created a new Invoice and two test records for Bird for testing.

Review 1

When trying to add impoundments, I was able to select them but when I pushed the button it didn't trigger an association.

https://github.com/user-attachments/assets/f3d88de9-88a8-40cd-a428-38a37fa8d43e

Chia let me know that when cleaning up the code yesterday she forgot to clean up one part and introduced a bug. And all let me know that when the impoundment gets assigned it would dissapear from the table because it was filtered to show records without an invoice

Review 2

Now I could select the record and when pushing the Add selected to invoice button they dissapeared after I refreshed the page.

https://github.com/user-attachments/assets/18371985-1754-48f9-974f-ae77e5ed194e

Chia recognized that she only refreshed the bottom view, and made it to where both views were refreshed.

Review 3

Realized that the impoundments showed up in the impoundments table and had the correct invoice associated with them. Also, realized that I had to Add invoice items manually to get them to show up in the Invoice Details page and subsequent PDF.

https://github.com/user-attachments/assets/8cb9cc8c-f884-42cc-a1d0-21edb0d9ed85

Everything worked as expected.

Approved.

Good to Go! 🚀

[patrickm02L]

7/16/24 Impoundments Review

Diana, Chia, and I met to discuss the functionality of the multi-select impoundments. The goal of the impoundments is make them selectable and move them from the "Provide Impoundments" table to the "Invoice Items" table.

Here are the key takeaways:

1. Description ID

• Verify and handle the details description to ensure the Invoice Description shows the device ID
• Consult Andrea about the Invoice Description

2. Automatic Refresh

• Refresh when submission button is triggered
• Ensure a banner appears after submitting multi-select options

3. Transaction amount should match impoundment fee amount

• Field mapping would need to be implemented when generating invoice items from selected impoundments, so that the transaction amount pulls from the associated impoundment fee

4. Invoice_item table location

• In test the view ID is moving from 1044 to 1059

5. Resize checkboxes

• Look at the finance CSS to see how checkboxes were resized

[chiaberry]

Test app ready for re-review

Patrick brought up question of deleting Invoice Items, and if anything should happen when invoice items are removed.

[dianamartin]

7/25/2024

@chiaberry

• Patrick and I synced and I think having the standard knack "Delete" button there is fine. I can build a knack button on the "Impoundments Table" (below) and make a trigger happen to "blank" out the connection.
• When I tested yesterday and today I noticed that main field not getting populated on the "Invoice Items" table is "Impoundment" (which is a "connection")

Changes Requested

• impoundment -
  • ex. 343: Lime, 01/02/2024 - 2 - $200
  • Template: {Impoundment No}: {Provider Name}, {Date of Impound} - {Number of Units} - {Impound Fee} (you can reference the impoundment Object table)
• Transaction Status - should be set to "UNPAID" (by default)

I'll added two invoice items to compare on this invoice: INV24-000782

• TXN24-003775 - is a manually entered one by a TPW SMS Staff

  You'll notice this record has the impoundment connection associated to it

• TXN24-003955 - was added using the "Add to invoice items" button

  You'll notice this record doesn't have the impoundment connection associated to it

To review records on the back end go to the "Invoice _item" table

[patrickm02L]

7/31/24

@dianamartin please make sure to add the trigger to clear out the Invoice ID if it's removed from the Invoice Items table, and can be found in the Provider table.

[chiaberry]

I opened this PR, the code is in the test app: https://github.com/cityofaustin/atd-knack/pull/161

I have checked to make sure the fields have the same ids in prod, so in theory nothing should need to be updated when moving it to the SMRT prod app.

If you need any dev assistance while I'm ooo, devs can help triage.

[dianamartin]

8/2/24

@patrickm02L

• in the Test Environment I added a "trigger button" called Remove connection. It should blank out the invoice connection.

Steps to remove connection

• Click "Remove" icon on Invoice Items" table
• Click "Disconnect" on Impound ID
• Invoice ID connection will become blank