cityofaustin / atd-data-tech

Austin Transportation Data & Technology Services
17 stars 2 forks source link

Add 'Void' as a Deficiency Status (TL) #1766

Closed atdservicebot closed 4 years ago

atdservicebot commented 4 years ago

As a ROW traffic control inspector, when I add a deficiency in error I need to indicate that the deficiency status is VOID.

Customer: Ryan, Nathan C, Kim DTS Manager: Tracy Note: Per Gita in 2018, deleting a deficiency is not an option. Will have to use deficiency status. Ready for Development? Yes

Acceptance Criteria:


Request Date: 2018-08-03 00:00:00

Request ID: DTS18-100385

Status: Backlog

Customer Priority:

Level of Effort: Small Project

DTS URL: https://atd.knack.com/dts#service-requests/view-issue-details/5b64c9f3fbbcf814ca4a0096

Migrated from atd-amanda #23

amenity commented 4 years ago

Nathan C. can be a point of contact for this.

TracyLinder commented 4 years ago

Email from Subha:

Hi Tracy/Nadin,

Reports for EX, 50510 and 50562 do not have deficiencies queried in any section. I think requirement doesn’t apply for these two reports. Please clarify.

Thanks, Subha

My Response:

Hi Subha,

Thanks for letting us know. You are correct and we can remove that from requirements.

Thanks,

Tracy Linder, Product Manager

TracyLinder commented 4 years ago

Update

Hi Subha,

The demo looks great. My only feedback is actually a new requirement, see below.

• On report 50514; Deficiency Corrected Date Field: The query should validate the deficiency status (FolderProcessDeficiency.SatusCode) instead of whatever it's currently validating. The field should populate based on the following: o If Status = Corrected, then field value = Complied Date (FolderProcessDeficiency.DateComplied)  If Complied Date is Null, then field value = Corrected; No Date o If Status = Deficient, then field value = Pending o See attached picture #1 - I've illustrated what your report would look like with the validation changes.

Thanks so much!

Tracy Linder, Product Manager

image

TracyLinder commented 4 years ago

I just updated the issue description with additional requirements that were emailed to Subha.

TracyLinder commented 4 years ago

Status: Subha will be sending us a demo soon. If that looks good, move this to DEV.

Sreelatha-BlazeKannan commented 4 years ago

@TracyLinder @Nadin-Nader - Subha Sent Demo on 7/1/2020 and waiting for Feedback.

TracyLinder commented 4 years ago

@Sreelatha-BlazeKannan @SubhaShroff - The demo looks great, please promote to Test.

Nadin-Nader commented 4 years ago

@TracyLinder @Sreelatha-BlazeKannan @SubhaShroff Deployment to DEV was on card #3324 and deployment to TEST was on #3325. Both connected successfully.

Other half of deployment needed to go to DevOps so Subha submitted a TASK to CTM DEVOPS TEAM ServiceNow request (REQ0056179 - SCTASK0080257). Its at the top of their "To-Do"

Next Steps ServiceNow request (REQ0056179 - SCTASK0080257 Needs to be completed

Need UAT and approval for it to be promoted to PRDO

Nadin-Nader commented 4 years ago

@Sreelatha-BlazeKannan @SubhaShroff Deployment of form has been done on DEV and TEST. Commit to promote to DEV has been completed by CM Team. @SubhaShroff Please let me know when this is ready to go to TEST then PROD after UAT

SubhaShroff commented 4 years ago

@Nadin-Nader I tested it in Dev. Its ready for Dev Testing. Please let me know, so that I can submit a ServiceNow request for TEST deployment of the commit.

Nadin-Nader commented 4 years ago

@SubhaShroff this has already been approved to move to TEST by Tracy

Nadin-Nader commented 4 years ago

Deployment to TEST with CTM Commit: d8a5cad09dbb - Task : SCTASK0080938

Waiting on Deployment to TEST, UAT then PROD

Created card #3342 for TEST DevOps deployment

Nadin-Nader commented 4 years ago

@TracyLinder this is ready for testing on TEST. I am closing #3342 as it is the deployment for TEST. STATUS:

Ready for UAT on TEST then Deploy to PROD

SubhaShroff commented 4 years ago

@TracyLinder @Nadin-Nader @Sreelatha-BlazeKannan This is tested in TEST. 50514, 50516 are working as expected for EX, RW, DS & ECV. Email report 50563( thats 50514) and 50568(email report of 50516) couldn't be tested with my email-id due to recipient email id validations set in TEST. Otherwise, its ready for TEST testing.

TracyLinder commented 4 years ago

UAT Results

50514 Tests

Test 1

Result: Failed

Test 2

Result: Passed

50516 Results

Test 1

Result: Failed

TracyLinder commented 4 years ago

@SubhaShroff @Sreelatha-BlazeKannan

UAT for this failed. My testing notes are available in the above comment, and the acceptance criteria has been updated. See below image where the updated portions are highlighted, and please let me know if there are any questions.

image

TracyLinder commented 4 years ago

Feedback to be incorporated by LIT during sprint 30.

SubhaShroff commented 4 years ago

@TracyLinder Yesterday, I updated the reports 50514, 50516 as per the updated requirement in UAT comment. I sent you the reports output as pdf files to you in email. The pdfs are the result of the same folder (12344083) that you have tested in TEST instance. So, please review it and let me know your feedback.

Sreelatha-BlazeKannan commented 4 years ago

@TracyLinder , @Nadin-Nader Reports (50514 & 50516) updated and submitted for review on 07/28/2020

TracyLinder commented 4 years ago

Review Notes:

I reviewed the 2 reports provided by @SubhaShroff

50516 Feedback for Subha:

System Deficiency Deficiency Status On Report? Report Status Pass/Fail Notes
Missing Corrected No N/A Pass N/A
Imporperly Located Deficient Yes Pending Fail Report status should be: Non-Compliant
Blocked Void No N/A Pass N/A
No Permit Null Yes Pending Fail Report status should be: Non-Compliant
In road during peak hours Corrected Yes Non-Compliant Fail Deficiency should not populate report
Sreelatha-BlazeKannan commented 4 years ago

@TracyLinder , @Nadin-Nader - Subha completed the changes and sent an email to Tracy on 08/04/2020 and waiting for feedback.

TracyLinder commented 4 years ago

@Sreelatha-BlazeKannan @SubhaShroff the report you sent me on 8/4 looks great. Please promote this work to test.

Nadin-Nader commented 4 years ago

@Sreelatha-BlazeKannan @TracyLinder @SubhaShroff I have deployed 50510 this to DEV and TEST.

Nadin-Nader commented 4 years ago

@Sreelatha-BlazeKannan @SubhaShroff i have deployed Report 50514 to DEV and TEST

SubhaShroff commented 4 years ago

Thank you @Nadin-Nader. @TracyLinder @Nadin-Nader @Sreelatha-BlazeKannan I tested 50514, 50516( for the fixed UAT comments) in DEV and TEST for all four folders: EX, DS, RW & ECV. Its ready for your testing in DEV as well as TEST with updated reports.

TracyLinder commented 4 years ago

I just tested in TEST, and this looks great! I'm going to schedule some UAT with stakeholders before approving a promote. Thanks @SubhaShroff

TracyLinder commented 4 years ago

Meeting w/ Stakeholders scheduled for 8/18 @3pm.

TracyLinder commented 4 years ago

I tested this with the stakeholders today & they approved for prod.

Approved for production. 🎉

SubhaShroff commented 4 years ago

Thank you @TracyLinder. @TracyLinder @Nadin-Nader PROD Deployment requests are submitted: SCTASK0090973, SCTASK0090979

SubhaShroff commented 4 years ago

@TracyLinder @Nadin-Nader @Sreelatha-BlazeKannan PROD Deployment is done.

TracyLinder commented 4 years ago

Stakeholders have been informed; closing ticket.