cityofaustin / atd-data-tech

Austin Transportation Data & Technology Services
17 stars 2 forks source link

Enable COACD button on all Knack login URLs, add fancy buttons, and document process #3924

Closed amenity closed 3 years ago

amenity commented 4 years ago

If I log out, or trying to access a valid URL (e.g. https://atd.knack.com/vza#my-assignments/) without being logged in, the login screen I get is missing the "Sign in with COACD" button.

Apps to check:

URL tested: https://atd.knack.com/vza#my-assignments/assignment-details/5f3db2b4911f490a5ab49321/

Open URL on Browserstack

Property Value
Device iPhone XR
Browser Mobile_safari
Operating System iOS 12.0
Resolution 828 x 1792 px
Screen size 6.1 in - 2.56 x 5.54 in
Viewport 414 x 896 dp
Aspect Ratio 19.5 : 9

Screenshot Attached Screenshot URL Screenshot URL

Click here to reproduce the issue on Browserstack

amenity commented 4 years ago

In the custom code we have a list of pages where we show the COACD pages; need to make a list of all pages and add to the code. @johnclary will help with this.

amenity commented 4 years ago

@ChrispinP — please add to Knack docs

SurbhiBakshi commented 4 years ago

@johnclary , @ChrispinP - meeting scheduled for Sept 15th

SurbhiBakshi commented 4 years ago

Rescheduled meeting to Sept 24th, had to postpone earlier one

SurbhiBakshi commented 4 years ago

@amenity - We were not able to get this done yesterday. @johnclary is going add documentation. @ChrispinP and I are working on the first step - adding a big button, and then we will add the sign in functionality to all the pages based on the documentation John is adding to the wiki. Rescheduled meeting to October 5th.

amenity commented 4 years ago

@SurbhiBakshi @johnclary thanks for the update. Can you all implement this in Data Tracker as well during the work session?

For some reason I thought it was already implemented there, but yesterday during #3914 Billy pointed out that he has to use a particular URL in order to use his COACD login. Otherwise he needs to use a Data-Tracker-specific login but he has trouble keeping track of that password.

amenity commented 4 years ago

~30 Data Tracker pages will need this. 😅

johnclary commented 4 years ago

@SurbhiBakshi @ChrispinP list of apps to update is in the issue description

amenity commented 4 years ago

@JaceDeloney @moorerst @TracyLinder — heads up, this enhancement is coming to your apps at some point. :)

amenity commented 4 years ago

@ChrispinP @SurbhiBakshi @johnclary - making this into an epic so it doesn't stay in progress 4ever. Please create sub-issues for the chunks you do together and close as you go.

SurbhiBakshi commented 4 years ago

Met with @mddilley today to talk about this need. Used the Finance Portal sign in buttons as reference.

amenity commented 4 years ago

@mddilley - do you want me to make you an issue for 👆? We're definitely eager to get #4251 taken care of soon. :)

mddilley commented 4 years ago

@amenity Yes, that would be great. Thanks for checking in on this, and I'm eager as well after the VZA screen sharing the other day!

amenity commented 4 years ago

Super, thanks: https://github.com/cityofaustin/atd-data-tech/issues/4390

ChrispinP commented 3 years ago

Enabled all login pages for TDSD with COACD login. Pending any metadata changes. JS and CSS working as expected. Non-COA login working as expected.

dianamartin commented 3 years ago

I had add the new code that Mike created to the Street Banners app and it passed all the browser tests, the sign-in pages showed up as intended. I moved on to the SMB Tracker, I realized that various applications already had some COACD Sign-in buttons enabled.

I continued to test their various home pages to see if I could find a sign-in page that wasn't configured to see if I even had to add the new code. I found a page and added the code, without modifying the existing code. The login page duplicated the big buttons from the previous code that was already there, so I removed it. I decided to test the SMB Tracker's login pages on the various browsers and discovered that all browsers except Internet Explorer showed up correctly.

I thought perhaps it was just a fluke, but then I tested only on Internet Explorer v. Chrome to see if the same situation occurred. It did, the big button view that I see on Chrome looked like a sign-in page that wasn't updated.

image.png

I think the code needs to be revised on a handful of applications. When I tested "Street Banners" works properly. SMB, AMD, Finance, DTS Portal do not, haven't tested the other apps yet.

johnclary commented 3 years ago

@dianamartin are there any console errors on Internet Explorer? It's very possible Mike used a javascript function that is not supported in IE.

dianamartin commented 3 years ago

@johnclary Didn't occur to me to check that, but that makes sense that could be the issue. I'll investigate it

dianamartin commented 3 years ago

not seeing any console errors on this page

image

SurbhiBakshi commented 3 years ago

@johnclary, @dianamartin, @mddilley and @ChrispinP - Unless you have already tried it out, we can test the COACD button on the New Builder on the Test VZA - 3rd Feb 2021 application. I got COACD logins enabled on it recently.

johnclary commented 3 years ago

great idea!

SurbhiBakshi commented 3 years ago

@johnclary, @dianamartin, @mddilley, and @ChrispinP - Moved the Test instance of VZA to the New Builder and was able to login using CoA credentials.

ChrispinP commented 3 years ago

I have updated the SSO code for both TDS and it is now in RPP with all login pages enabled for SSO.

ChrispinP commented 3 years ago

HR is now updated with SSO and all login pages enabled for SSO.

ChrispinP commented 3 years ago

DTS SSO code verified and enabled. Updated and cleaned up code.

SurbhiBakshi commented 3 years ago

hi @ChrispinP - I had enabled SSO on the DTS application when I migrated it and updated the code here. If you made changes to limit the clickable area, please make sure to update in Github.

ChrispinP commented 3 years ago

Will need to create new SSO token for ROW once new app is established. ROW Prototype was the only ROW app with SSO enabled so I updated code for clarity and enabled on all login pages.

johnclary commented 3 years ago

Oh dang I forgot we had SSO setup for the ROW prototype. I think we can actually migrate that without too much headache. We'll need to take a look.

ChrispinP commented 3 years ago

@johnclary Ill go ahead and migrate it. gonna look at ROW holistically tomorrow, we should touch on data migration during or after grooming.

johnclary commented 3 years ago

@ChrispinP would you just make a backlog issue for it and we can pick it up during grooming?

dianamartin commented 3 years ago

Closing issue since ROW SSO configuration happened in a different issue #5993