cityofaustin / atd-data-tech

Austin Transportation Data & Technology Services
17 stars 2 forks source link

Fee Logic Updates to TURP & EX (On PROD 🎉🎉) #6844

Closed TracyLinder closed 2 years ago

TracyLinder commented 3 years ago

This single issue covers the development for removing old fee logic and implementing new fee logic on the RW-TURP & EX permits.

TURP

Remove the following functionality:

Create new fee logic for the fees provided below:


EX

Remove the following functionality:

The following fee procedures and logic need to be removed for the EX fees:

Create new fee logic for the fees provided below:


image

TracyLinder commented 3 years ago

This is ready for development. FYI @Nadin-Nader @vschandramouli @Sreelatha-BlazeKannan

TracyLinder commented 3 years ago

AC Update:

This was removed:

Sreelatha-BlazeKannan commented 3 years ago

@Nadin-Nader , @TracyLinder - One quick config commit submitted for Insert & Run procedures. here is the commit id: 259c194a7. Could you please approve and create task id for me.

Nadin-Nader commented 3 years ago

@Sreelatha-BlazeKannan this has been sent to CTM to deploy to DEV under SCTASK0163113 (lookup 50200)

Nadin-Nader commented 3 years ago

Status: Waiting on DevOps CM Team to deploy to DEV. Under SCTASK0163113

Sreelatha-BlazeKannan commented 3 years ago

** Status @Nadin-Nader , @TracyLinder - Completed Development for RW-TURP and working on for EX

Nadin-Nader commented 3 years ago

@Sreelatha-BlazeKannan @TracyLinder DEV deployment has been completed. @Sreelatha-BlazeKannan please UAT on DEV

Nadin-Nader commented 3 years ago

Status: Sree is currently testing this

Nadin-Nader commented 3 years ago

Added to AC:

Make sure Extension Fee inserts based on Property & Street Information irrespective of the WorkType: PVT Long Term

TracyLinder commented 3 years ago

Currently blocked by #6842 commit.

Sreelatha-BlazeKannan commented 3 years ago

@Nadin-Nader , @TracyLinder - sent Demo for EX folder for your review and approval. All AC working as expected. if you have any questions please do let me know.

Sreelatha-BlazeKannan commented 3 years ago

@Nadin-Nader , @TracyLinder - AC Update according to Kim and Paloma

For Work type Franchised utility (3) No Extension fee and No row-usage fee must be added

For all City Departments work types and will have extension fee but not Row-usage fee

For Private Development work type will have Extension fee and row usage fee

I will work on the changes and update the card. MicrosoftTeams-image (1) Yellow Highlight = City Departments = Generate Application Fee ONLY Red Cross Through = REMOVE Blue Circle = Franchised Utilities = Do NOT generate Application Fee Black Circle = Private Developer = Generate Application Fee AND ATD Tech Surcharge

TracyLinder commented 3 years ago
Screen Shot 2021-09-20 at 10 12 00 AM Screen Shot 2021-09-20 at 10 11 54 AM
TracyLinder commented 3 years ago

Update - Emergency Permit Fees

The emergency permit fees for both EX & TURP have been removed by stakeholders. Sree will comment out the code in case we decide to use it in the future. Currently this work is in local.

TracyLinder commented 3 years ago
Screen Shot 2021-09-20 at 5 03 44 PM Screen Shot 2021-09-20 at 5 02 55 PM
TracyLinder commented 3 years ago

@vschandramouli FYI - the emergency permit fees were not approved & are being removed,.

TracyLinder commented 3 years ago

@Sreelatha-BlazeKannan & @Nadin-Nader do you know when we will be ready for UAT on this one?

TracyLinder commented 3 years ago

Update

Sree will:

Tracy will:

TracyLinder commented 3 years ago

Feedback from Kim:

  1. ATD Tech Surcharge only applies to private development permits
  2. The secondary permit fee on EX should not have a surcharge.
  3. There is no secondary fee on RW

FYI @Sreelatha-BlazeKannan

Sreelatha-BlazeKannan commented 3 years ago

@Nadin-Nader , @TracyLinder - I have updated the changes as per above feedback; Submitted DEV Deployment plan for EX-FEE UPDATES ONLY. Please create task id for the commit id: c407e2de383c. And working on the RW changes

Nadin-Nader commented 3 years ago

@Sreelatha-BlazeKannan i have sent this over to the DevOps CM Team to deploy to DEV under SCTASK0168582

Nadin-Nader commented 3 years ago

Status: Waiting on DevOps CM Team to deploy to DEV under SCTASK0168582

Sreelatha-BlazeKannan commented 3 years ago

@Nadin-Nader , @TracyLinder - EX Changes are moved to DEV and I tested the same. All looks good. Please UAT The same to move to TEST

Sreelatha-BlazeKannan commented 3 years ago

@Nadin-Nader , @TracyLinder - Submitted DEV Deployment plan for RW Changes and informed George to make the move asap. Here is the commit ID: 2fb16c5c2e95 for your reference. Kindly create task id for the same.

Nadin-Nader commented 3 years ago

@Sreelatha-BlazeKannan i have sent the RW changes in commit 2fb16c5c2e95 to the DevOps CM Team to deploy to DEV under SCTASK0169045

Nadin-Nader commented 3 years ago

Status: EX changes are in DEV ready for UAT to move to TEST RW changes have been sent to DevOps CM Team to deploy them to DEV under SCTASK0169045

TracyLinder commented 3 years ago

Update

Please promote to TEST so UAT can continue.

Sreelatha-BlazeKannan commented 3 years ago

@Nadin-Nader , @TracyLinder - I tested both RW & EX changes and all working as expected. Submitted TEST DP plans and here is the order to promote the changes to TEST. Please ask George to promote the changes as he did the DEV promotion.

Order to Promote the changes from DEV to TEST

  1. 259c194a7 – It is already in TEST
  2. 884bded88b96 (validlookup) – Promoted by George (c0a93748cf4d9e147208b97b394e667eee9118c8)
  3. c407e2de383c – (EX Updates) – Promoted by George
  4. 2fb16c5c2e95 – (RW Updates) - Promoted by George (70fe8cd2a7c009bfefb636001e19aa229dc6998d)
Nadin-Nader commented 3 years ago

@Sreelatha-BlazeKannan

Status: George is currently deploying this to TEST under SCTASK0169134

Nadin-Nader commented 3 years ago

@Sreelatha-BlazeKannan George has informed me that this is ready for UAT on TEST. Please test before our meeting or we can try to test at our meeting.

Nadin-Nader commented 3 years ago

Status: Ready for UAT on TEST

Sreelatha-BlazeKannan commented 3 years ago

@Nadin-Nader , @TracyLinder - I have tested in TEST Environment both EX & RW-TURP, all working as expected.

TracyLinder commented 3 years ago

UAT ISSUE 1

During testing i encountered system errors related to issue #1802 . I've asked Nate & Subha to roll back 1802 ASAP.

Screen Shot 2021-09-28 at 10 05 52 PM

Update 9/29 @9am #1802 has been reverted. Ready to re-test

TracyLinder commented 3 years ago

Note to Us: We're going to need to think of a better way to keep track of the bugs that need to be fixed before we go to PROD.

TracyLinder commented 3 years ago

UAT ISSUE 2

Reported by me (Tracy)

ATD Tech Surcharge did not insert on RSN 12666674 with the TURP extension fees. I saved 'Approved' attempt on TURP Review (50520) and the system: ✔️ Inserted TURP Permit Fee - Extension ✔️ TURP ROW Usage Fee ❌ FAILED to insert ATD Tech Surcharge ❓The system did not bill the fees. I'm not sure if that's correct yet.

Feedback from Stakeholders: It's ok if the ATD tech surcharge doesn't insert here. They have to update the cost manually often so it's cool for them to insert it manually.

TracyLinder commented 3 years ago

UAT ISSUE 3

Reported by Tracy

(On existing folder) I am unable to save 'Extension Granted' attempt on process Permit Extension (50680) due to system error "Error calculating parking space fee. Contact the help desk."

fee logic bug.jpg

TracyLinder commented 3 years ago

TURP Test Plan is Ready Here

TracyLinder commented 3 years ago

UAT ISSUE 4

Reported by Tracy

When I saved the Approved attempt on process (50520) TURP Review, the system ❌ didn't ❌ insert a ROW usage fee (it should have). Nothing happened when I tried to add the TURP ROW Usage Fee from Insert + Run.

TracyLinder commented 3 years ago

UAT ISSUE 5

Reported by Kim

Per Kim, on TURP, when Emergency info is Yes, no fee should be inserted. She's going to talk to Paloma or Ryan to confirm we need to make changes and she'll get back to us.

TracyLinder commented 3 years ago

UAT ISSUE 6

Reported by Kim

On expired TURP permits, when 'extension granted' saved and the extension fees are paid, the system is not updating the folder status to Active.

The TURP extension workflow is not updating the folder expiration date w/ the new extension end date.

Screen Shot 2021-09-29 at 10 43 29 AM
TracyLinder commented 3 years ago

TURP UAT is complete. Ready for Bug fixes.

TracyLinder commented 3 years ago

UAT ISSUE 7

Reported by Tracy

Status/Updates:

During portal application for EX - Project Connect, on the Property & Street Info page, the system is showing fields for the TURP & SCP folders.

Screen Shot 2021-09-29 at 7 39 28 PM
Screen Shot 2021-09-29 at 7 45 19 PM
TracyLinder commented 3 years ago

UAT ISSUE 8

Reported by Tracy

Can't issue Franchised Utility permit; system requires me to insert a Right-of-Way Contractor people record. (This may not be a bug.)

  1. Is this how it's working on PROD, or is this a bug?
  2. When i updated the franchise people record to Right-of-Way Contractor, i was able to issue the permit.

Franchised Issue Error.jpg

TracyLinder commented 3 years ago

We will be fixing the bugs today & then moving to PROD:

SubhaShroff commented 3 years ago

@Nadin-Nader @TracyLinder @Sreelatha-BlazeKannan SCTASK0170364 - submitted to for DEV promotion of Issue 7.

Nadin-Nader commented 3 years ago

@Sreelatha-BlazeKannan the new changes have been sent to DevOps CM Team to deploy to DEV under SCTASK0170433 Once UATd we will send to TEST and approve for PROD

Nadin-Nader commented 3 years ago

Status: Sent to DEVOPS to be deployed to DEV under SCTASK0170433

SubhaShroff commented 3 years ago

@TracyLinder @Nadin-Nader
Summary for Bug -7: First commit is in TEST. Two more fields had to be removed so did another commit. And SCTASK0170435 is submitted for DEV & TEST deployment of the 2nd commit. Once its in TEST, I can test it.

Nadin-Nader commented 3 years ago

2 out of the 4 commits had EX changes. We decided to revert any EX changes and proceed with the rest to go to PROD under SCTASK0170454

TracyLinder commented 3 years ago

Update / Critical Bugs

There may be service interruptions with TURP & EX permits. The full impact is unclear as of 9pm

Two bugs/failures have been identified on the EX folder; both are critical: TEST#: 2021-047486 EX

  1. The system fails to insert the Right-of-Way Contractor record on the folder.people tab.
  2. The system fails to create an EX folder for each street submitted by the applicant. Only one folder is being created for all streets.

We are launching tonight, with major issues.

Here's what we did:

  1. Rolled back both commits on 6844 - 2 (EX) (c407e2de383c & c0a93748cf4d9e147208b97b394e667eee9118c8)
  2. Promoted the other commits to PROD.

Moving Forward

  1. Tracy will smoke test EX & TURP tonight; I'm just not sure if the promotes are done yet.
  2. We sync with the project team tomorrow am to assess the situation and identify solutions.