cityofaustin / atd-data-tech

Austin Transportation Data & Technology Services
17 stars 2 forks source link

[Bug] Incorrect locations/signals in Signal Engineer Areas AGOL layer #9804

Closed dianamartin closed 1 year ago

dianamartin commented 2 years ago

John C. DTS

Follow-up of #9678

This makes me wonder if we should re-process all the Data Tracker locations/signals since the layer has changed significantly since we last did this - ?

Context: The location update script was pointing to an old signal engineer area layer. This change points the script to the official GIS datamart layer.

amenity commented 2 years ago

Thanks @dianamartin!

@chiaberry @johnclary - do you think this belongs in the backlog or needs scoping?

johnclary commented 2 years ago

It should be possible for an apps person to knock this out by following these steps.

amenity commented 2 years ago

@dianamartin - will you please add an estimate? Thanks!

dianamartin commented 1 year ago

Brian G. was just trying to submit a DTS request about this today, 11/29

SR Number TMC22-32400 22-00439614 This is showing NORTHWEST area but is actually NORTHEAST. Somehow our areas are not working correctly, at least for this one location

image @johnclary is this affected by this issue or a GIS feature/311 issue?

johnclary commented 1 year ago

@dianamartin this is probably related to this issue, but i will have to look at the knack records.

johnclary commented 1 year ago

@dianamartin - confirming that yes, this issue is the cause of the problem Brian observed.

dianamartin commented 1 year ago

Following steps from #9678 to update:

dianamartin commented 1 year ago

@johnclary for this issue, would I just update all the locations and signals so that it'll update via script?

johnclary commented 1 year ago

yes, by following these steps.

dianamartin commented 1 year ago

@johnclary yep, did that for this one off, but I can do that for the other locations. I'm gonna check it if updated over the weekend.

dianamartin commented 1 year ago

@johnclary well, it looks like LOC16-002630 still didn't update even though I followed those steps.. :(

johnclary commented 1 year ago

@dianamartin the location updater script is failing :/ it's a wild guess, but it may be related to the knack performance upgrades. this will need to be further triaged and estimated :(

amenity commented 1 year ago

Again: [Bug] Incorrect Area Engineer Designation for Signals 957 & 958

Potentially the same pattern (geospatial reference script) as the one disrupting the mechanism for assets in service requests that come over from 311

This needs Dev scoping.

Charlie-Henry commented 1 year ago

Synced with @johnclary about this and we're gonna try to refactor the old location updating script and roll it into atd-knack-services

Charlie-Henry commented 1 year ago

I've re-located all locations in the test data tracker app. I'm curious how we want to end up validating some of these.

@dianamartin LOC16-002630 shows NORTHEAST for signal engineer area.

dianamartin commented 1 year ago

@Charlie-Henry awesome, thanks for the update

Charlie-Henry commented 1 year ago

Looks like this is running alright on a test Data Tracker app. @dianamartin is there anything else we should look at before we switch this over to production?

dianamartin commented 1 year ago

@Charlie-Henry it should be a straight forward script, I think

johnclary commented 1 year ago

@Charlie-Henry i'd say you should:

  1. Test this locally against production (yolo...)
  2. Request review on the knack servies and prefect PRs
  3. I will tear down the legacy script
Charlie-Henry commented 1 year ago

@johnclary Diana and I yolo'd this last week 👍

One bug I am fixing then we can PR then merge and close this out!