Closed TracyLinder closed 2 years ago
@SubhaShroff can you please begin debugging this when you have a moment? Thank you.
@TracyLinder @Nadin-Nader This happened - as the user first selected yes for Secondary on infos and saved for later after going beyond people page. The Excavation Permit Fee - Secondary is added with surcharge. The fees are adding with Continue button on people page. Later the user edited the incomplete permit and this time selected No for Secondary and went ahead and then this time 'Excavation Permit Fee - New' is added with ATD surcharge. COS payment is done for all these fees only with the submission, collectively. I checked the info value change from Yes to No, in Audit. It's not just PWD, it can be any permit that has Secondary fee associated. I see that except Franchised Utility, the rest of all EX permits have Secondary fee. I tried another permit, WPD in the same sequence as I explained above and got the double fees added as in PROD. V7 TEST rsn: 12874233 (EX-WPD) 12874232 (EX-PWD)
Tested on V6 DEV (V6 test giving me error to move ahead with application on portal at a stage). RSN - 11904470 (Austin Energy) - it has both fees now. And its happening in V6 too. There was a possibility it could have happened in V6 also if any user tried changing the info value later for incomplete permit in PROD.
The same can happen with 'Excavation Permit Fee - Emergency fee' also. Solution: Fees that are added based on info values shouldn't be added until the user submits the application. That can help.
@SubhaShroff thank you for the analysis. So we need a new rule that says not to insert fees until the application is submitted? Is that possible?
@TracyLinder I think we can do that by shifting the code logic to SUbmit button procedure. I will check that and get back to you. Thanks.
@TracyLinder we can do this. Please let me know if we can proceed on the fix. And for all the subtypes of Ex(except Franchise Utility).
@SubhaShroff Let go ahead and send this to the sandbox
@TracyLinder @Nadin-Nader SCTASK0241412(for 0700c8f9e37a commit) request is submitted for Sandbox deployment.
@Nadin-Nader The changes are in SB.
@TracyLinder @Nadin-Nader Should we move this to DEV, as its fee related?
@Nadin-Nader @TracyLinder SCTASK0243075 (0700c8f9e37a) is submitted for DEV deployment.
@Nadin-Nader @TracyLinder Tested it on DEV Portal/BO. RSN: 12532913 - EX - PWD
Can I get it on TEST?
@Nadin-Nader @TracyLinder SCTASK0244170 is submitted for TEST Deployment.
@TracyLinder @Nadin-Nader Tested on TEST - 2022-019340 EX - selected Secondary YES --> Save for later --> edited (kept secondary YES) --> submit. The 'Excavation Permit Fee - Secondary' is added with ATD surcharge. 2022-019341 EX - selected Secondary YES --> Save for later --> edited (secondary NO) --> submit. 'Excavation Permit Fee - New ($290.00' is added with ATD surcharge. No duplicate fees added.
Ready for UAT.
Waiting for the UAT.
@Nadin-Nader @TracyLinder This is approved for PROD in today's ROW ATD call. Submitted the PROD deployment - SCTASK0245997.
@TracyLinder @Nadin-Nader This is deployed in PROD.
Test ID 13014944. Prod is good. Closing.
Example: