search

civictechdc / opendatadc

GNU Affero General Public License v3.0
15 stars 24 forks source link

Change favicon #52

Open gregjd opened 7 years ago

gregjd commented 7 years ago
screen shot 2017-03-06 at 8 39 50 pm

Currently the favicon is white and squished. At the very least, we don't want it to look squished.

But we also may not want it to be white. Do we want it to be red, since it is Code for DC's? This semi-relates to the overall design of the site. (See also: https://github.com/codefordc/opendatadc/issues/47)

This might help for changing the favicon: http://docs.ckan.org/en/latest/maintaining/configuration.html#ckan-favicon

gregjd commented 7 years ago

I have no idea where the favicon is being drawn from. We don't seem to have a file in the location specified by that link. It looks like we're using logo.png from this directory, but it doesn't seem to be referenced in the site's HTML (see search results here).

jalbertbowden commented 7 years ago

i submitted a pull request to the main site's repository with a directory of assets. there's a bunch of favicons in it.

jalbertbowden commented 7 years ago

here's the url of where it is pulling from:
http://data.codefordc.org/c4dc-logo-white-30x58.png

mcculleydj commented 6 years ago

We can and I think should just make this a static resource. In our extension we can add an icon file to .../public/base/images with a unique name. Public resources added to extensions are combined with the resources CKAN ships with e.g. ckan.ico. So in the .ini you can just use the same path /base/images/ to set the icon we want to use. I'm not actually seeing how this:

<head>
    ...
    <link rel="shortcut icon" href="/c4dc-logo-white-30x58.png">
<head/>

is getting set. Nothing greps from the src files I'm looking at.

Any chance we have an image that is circular or square (to prevent the squish problem)?

jalbertbowden commented 6 years ago

https://github.com/codefordc/codefordc.github.com/tree/master/assets/img/logo