cjolif / dojo-todo-app

Dojo ToDo App
Other
28 stars 15 forks source link

I ran into an odd problem when updating a completed item. #30

Closed edchat closed 12 years ago

edchat commented 12 years ago

I ran into an odd problem when updating a completed item, if I go to the Reminders list, (has 3 items) mark one complete. Then get the completed one to show up in the Completed list, then update the completed item, maybe change the Notes and click done. Then when I switch back to the Reminders it only has one item instead of 2, and switch back to the Completed, it has 2 copies of the completed item listed.

eric-wang commented 12 years ago

fixed in commit: https://github.com/cjolif/dojo-todo-app/commit/2d5abb363dbb20cf4291f8e9d5b176acdc4b65d9.

edchat commented 12 years ago

I found another problem, with this scenario (which I fixed with pull request 32). 1) Show the Reminders list, and check Item 1. 2) Select Item 1 to see it's details, update the item title and hit Done. The Item 1 was moved to the Completed list, but it will not have the updated title.
To fix this problem I did not move the item to the completed list if is was being selected to show it's Details. So that item will now stay in the list until some other action is take besides showing it's Details.

edchat commented 12 years ago

I re-opened this because there is still one case where a problem still exists. 1) go to demos/toDoMvcApp/app/ 2) check Item 1 in the list. 3) select item 2 in the list, then go back to the list Item one is checked but it was not moved to the Completed list, (because it did not get a transition out from the list). This is a minor issue.

eric-wang commented 12 years ago

I re-product this issue, it happened on the first time when the application start

eric-wang commented 12 years ago

it is fixed when merge data into one json file