search

cjolif / dojo-todo-app

Dojo ToDo App
Other
28 stars 15 forks source link

Changing the orientation on iphone breaks the display #86

Closed cjolif closed 12 years ago

cjolif commented 12 years ago

When I run the app on iPhone change 2 or 3 times the orientation I ends up with a broken display. I don't think I had that in the past.

@edchat can you reproduce?

edchat commented 12 years ago

I was able to reproduce this on iTouch and iPad but not on Android phone, I may have seen this in the past but I am not sure. For me it will usually correct itself on the next orientation change, but I will see if I can figure out what is causing the problem.

edchat commented 12 years ago

Well when I added a console log to the onResize: function() in the Layout controller, I saw that onResize was not called when the problem occurred. The constructor calls this.bind(win.global, "resize", lang.hitch(this, this.onResize)); Which works fine when the problem does not occur, so it seems like an ios bug outside of dojox.app?

cjolif commented 12 years ago

@edchat @edurocher can certainly advise us here, as dojox/mobile certainly facing the same kind of issues? Maybe onorientation should be listen to in addition to onresize. @edurocher ?

edurocher commented 12 years ago

All I can say is that, in dojox/mobile, we just listen to orientationchange on iOS. But onresize is also called, just before onorientationchange if I remember correctly.

cjolif commented 12 years ago

@eric-wang can you let us know why Layout controller is not listening to orientationchange? Did you notice this was not needed? (see the problem above it seems to create issues).

cjolif commented 12 years ago

As this is a dojox_application issue I'm closing this one if favor of the dojox_application issue above. Please continue discussion there if needed.