cjss-group / CJSS

A CSS based web framework
https://cjss.js.org/
MIT License
670 stars 20 forks source link

Plugins: resolve #14 #37

Closed c-harding closed 5 years ago

c-harding commented 5 years ago

Let's go! That took rather more hours than I was hoping, but everything is working with plugins #14 now. The build has been split up into four stages (resolving #26 at the same time): data, prepare, body and script. These are run sequentially, and for each stage exactly one "mode", i.e. plugin, can be used. Each stage can modify the data attributes (which are now calculated individually for each element), and the intention is that only the body stage is used to replace the child elements (but the script stage can be used to bind event handlers etc).

Please check through the code before merging, it's late and I haven't tested it too much yet.

KargJonas commented 5 years ago

image Jesus - You are insane :sweat_smile: It'll take me a while to review it all. Looks sick so far!

KargJonas commented 5 years ago

We should merge this as quick as possible so that we can work on some other stuff without creating conflicts. @scottkellum