functionFromString seems to be a pointless abstraction of Function

[c-harding]

The function functionFromString seems to just be the Function constructor with the arguments in a different order. It then returns a subclass of Function, with a method run which is just a rearrangement of the argument order of apply inherited from Function.

I would propose removing the EvalFunction class, as it does nothing that can’t be done with Function.prototype.apply, Function.prototype.call and the function itself.

I would also propose removing functionFromString, it is just new Function with a different argument order.

https://github.com/scottkellum/CJSS/blob/367dad1d442b7df2adf74b705b7934a7018b0f67/src/functionFromString.js#L4

[KargJonas]

Sure. Originally I left it in to allow us to omit context, which allowed for cleaner code.

[c-harding]

Sure. Originally I left it in to allow us to omit context, which allowed for cleaner code.

That can be done by just calling the function, e.g.

const render = new Function(arg1, arg2, "...");
render(a, b);