ckan / ckanext-showcase

A ckan extension to showcase datasets in use
GNU Affero General Public License v3.0
43 stars 77 forks source link

Maximum dataset max limitation that a showcase can hold #145

Open quinoescobar opened 2 years ago

quinoescobar commented 2 years ago

Version CKAN 2.9.3; Showcase 1.4.8

Describe the bug Trying to create a showcase with around +1600 datasets

Expected behavior

Additional details

The error with a showcase with more than 1041 datasets is cause but the huge boolean clause generated by this : https://github.com/ckan/ckanext-showcase/blob/master/ckanext/showcase/logic/action/get.py#L118

It can be easily change the maximum number of clauses allowed with the query by changing the maxBooleanClauses property (https://solr.apache.org/guide/6_6/query-settings-in-solrconfig.html#maxbooleanclauses) but I reckon its better to modify the query's logic per se and modify the templates to allow the pagination.

Though the showcase can hold up to 1000 datasets without problem, It's only shown 100. This is hardcoded here https://github.com/ckan/ckanext-showcase/blob/master/ckanext/showcase/logic/action/get.py#L121