ckan / ckanext-showcase

A ckan extension to showcase datasets in use
GNU Affero General Public License v3.0
43 stars 77 forks source link

read: "Manage" link can overlap (with large images) #87

Open Chealer opened 4 years ago

Chealer commented 4 years ago

When browsing with administrative privileges, the read page displays a "Manage" ("Éditer" in French) link allowing admins to edit the application. This link is positioned pretty much at the top, which makes sense given its importance. It is also wisely positioned to the right, to preserve vertical space.

More precisely, the element is absolutely positioned, 36 pixels below its parent's top. This is surely to prevent overlap between Manage and long titles. But unfortunately, that only moves the problem down. It works with the first 1 or 2 lines of titles, but leaves several possibilities for overlap, with either:

  1. A title which fills at least 2 or 3 lines
  2. An image which takes the full width
  3. If there is no image, a description which takes more than 1 line

The following screenshot demonstrates case #2: showcase Manage


We are experiencing this with showcase 1.2.0, but looking at the code, I am convinced that master (1.3.0) is also affected.

The proper way to avoid such overlap is to reserve the space taken by the element, which can be done with relative positioning and using CSS float: right instead.