search

ckeditor / ckeditor4-workflows-common

Shared CKEditor 4 GitHub workflows.
1 stars 2 forks source link

Add workflow for updating workflows #1

Closed f1ames closed 4 years ago

f1ames commented 4 years ago

I decided to add the main/template action as a PR so we can review it and work as normal instead of creating it via GH editor which will be cumbersome.

Also the funny thing is that if this action will be included here it can auto-update itself too I suppose :thinking: So not sure if we should move it as template or leave here eventually.

~This is WIP since I need to test how it works.~ Checked in workflows-setup-test repo. The only issue there is that, since it is user (not organization) repo, CKEditor Bot has Collaborator access level which means it can't push new workflows - that's why it fails on push step (see e.g. https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-your-github-user-account/permission-levels-for-a-user-account-repository). However, based on logs you can tell it works fine creating/updating workflow files.

f1ames commented 4 years ago

Ready for review.

f1ames commented 4 years ago

The only issue there is that, since it is user (not organization) repo, CKEditor Bot has Collaborator access level which means it can't push new workflows - that's why it fails on push step (see e.g. https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-your-github-user-account/permission-levels-for-a-user-account-repository). However, based on logs you can tell it works fine creating/updating workflow files.

Ok, so it turns out that token with workflows permission needs to be used for both checkout/pull and push (as mentioned in https://github.com/EndBug/add-and-commit/issues/52#issuecomment-674377928).

f1ames commented 4 years ago

The only issue there is that, since it is user (not organization) repo, CKEditor Bot has Collaborator access level which means it can't push new workflows - that's why it fails on push step (see e.g. https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-your-github-user-account/permission-levels-for-a-user-account-repository). However, based on logs you can tell it works fine creating/updating workflow files.

Ok, so it turns out that token with workflows permission needs to be used for both checkout/pull and push (as mentioned in https://github.com/EndBug/add-and-commit/issues/52#issuecomment-674377928).

f1ames commented 4 years ago

@jacekbogdanski I have added dedicated token for pull and push actions and info to README about it - 3541055. It should be the last piece here hopefully :crossed_fingers: