Update and linting - Githubissues

claabs / epicgames-freegames-node

Automatically login and find available free games the Epic Games Store. Sends you a prepopulated checkout link so you can complete the checkout after logging in. Supports multiple accounts, login sessions, and scheduled runs.

https://hub.docker.com/r/charlocharlie/epicgames-freegames

MIT License

1.39k stars 93 forks source link

Update and linting #339

Closed WarningImHack3r closed 1 year ago

WarningImHack3r commented 1 year ago

Update all dependencies (up to pre-ESM versions)
Add missing @types/source-map-support
Fix missing quoting in entrypoint script
Misc. linting in TS files

claabs commented 1 year ago

Something about updating the tsconfig target to ESNext/es2022 changes how the config object exposes unset fields and breaks plugin-portal. I'll likely keep the target on es2021 until the bug is fixed: https://github.com/typestack/class-transformer/issues/1216

WarningImHack3r commented 1 year ago

Do you prefer waiting for a fix or merging like this?

claabs commented 1 year ago

I made my changes and I'm happy with it. Thanks for your contributions!

WarningImHack3r commented 1 year ago

Out of curiosity, what's the point of keeping both start scripts for the same action? Also, I've opened an issue at #340, please take a look at it once you've got time :)

claabs commented 1 year ago

Out of curiosity, what's the point of keeping both start scripts for the same action?

IIRC, the readme originally said to use start:ts when running locally. So if any non-Docker users scripted it or something, I just don't want to break it.

Also I cancelled the pipeline, since something is very wrong with Chromium 111, and APK doesn't store old versions so I can't downgrade to 110. It's best that a new image doesn't build until I figure it out.