search

claytonotey / paukn

The pitched audio knife - VST effect with various midi note controlled filters (lowpass, hipass, comb, decimator, granulator, digital waveguide)
11 stars 1 forks source link

LV2 version? #2

Open mxmilkiib opened 1 year ago

mxmilkiib commented 1 year ago

Hi, just wondering if you might consider an LV2 version in the future? There's libs like DPF and JUCE that could help in that process.

claytonotey commented 1 year ago

Hi. It wasn't a priority. I haven't used DPF before. I refuse to use JUCE - I have had bad experiences in the past and would not recommend it for anything. It tries to frameworkify everything and always forces you into a corner.

I was working on a huge overhaul of paukn which incorporates libsbsms features and an opengl gui library I wrote for realtime spectrograms. I was already planning on getting back to audio code in the next weeks, so thanks for the interest.

I will work on getting LV2 support along with all of this. This will actually help me factor the messy VST3 plugin code. VST3 note expression is pretty important for many of the changes I want to make - does DPF/LV2 have anything similar? In any case, the existing functionality should be compatible with DPF/LV2.

dromer commented 1 year ago

If you move to DPF you get vst2/3/lv2/clap (and dssi/ladspa) as well.

Not saying that's what you should do, but no vst3sdk can be considered a nice thing as well.

claytonotey commented 1 year ago

I'm looking into it.
Not as a replacement for the VST3 SDK, but for the other plugin formats as a fallback. DPF doesn't look like it deals with note expression properly. The vst3 SDK is not perfect, but using it directly seems to be the only way to actually be sure all the features will work properly in Cubase.

dromer commented 1 year ago

Which kind of note expression do you mean? I'm sure we can extend it if required. It aims to have proper compatibility with the specification.

claytonotey commented 1 year ago

Like this, where host events contain note specific parameters: https://github.com/claytonotey/paukn/blob/master/src/paukn.h#L266

I skimmed the DPF VST3 code and I didn't see this functionality implemented yet. https://github.com/DISTRHO/DPF/blob/main/distrho/src/DistrhoPluginVST3.cpp

It shouldn't be too hard but it might require refactoring some things, unless I'm mistaken and it's already implemented? I like the way DPF is structured and what it offers, so I'd like to use it in paukn, but I'll stick with my own VST3 code for now unless the noteID stuff is already in DPF.

Thanks for showing me.

I'm getting back into audio code after a break, but I'm not sure when I'll have time for this. I'm more focused on sbsms and realtime spectrograms and UI stuff for now, and not so much the plugin interface, which is my least favorite part.

dromer commented 1 year ago

@claytonotey do you mean https://github.com/DISTRHO/DPF/blob/main/distrho/src/travesty/events.h#L79 ?

It's implemented in the spec, but indeed not attached to any framework hook (yet) afaict. Paging @falktx ..

falkTX commented 1 year ago

note expression is a tricky thing, every standard does it a different way. we have MPE, MIDI2 things, VST3 and also CLAP. there is likely some common aspects between all of them, but I dont really follow the techniques used here so for the moment DPF does not have this and likely wont have it anytime soon. On the LV2 side such thing doesnt even exist, we would have to rely on MPE or MIDI2.