clegaspi / saml_reader

A tool to parse and verify SAML response data for MongoDB Cloud.
MIT License
7 stars 2 forks source link

Add certificate expiration comparison #48

Closed clegaspi closed 3 years ago

clegaspi commented 3 years ago

Summary of added functionality

This implements the feature in #47 which checks the SAML signing certificate expiration date against a comparison value, which is visible from the Atlas console. This is a test for certificate validity in lieu of having the actual certificate to do a proper validation.

Steps to complete

Implementation notes and additional changes

To do this, I had to do some refactoring not directly related to this feature:

In large part, this was done to allow for both regex-type validation and/or the execution of an arbitrary validation function. This was needed to validate the entered date as a valid date, because this is not (easily) doable with regex. It future-proofs for any other inputs that we may want to validate with an arbitrary function.

clegaspi commented 3 years ago

I hate rebasing...accidentally based this on master, when it should have been on v_0_0_4.