clegaspi / saml_reader

A tool to parse and verify SAML response data for MongoDB Cloud.
MIT License
7 stars 2 forks source link

Werkzeug 3.0.1 breaking change results in the application refusing to run due to unrecognised import. #85

Closed josh-allan closed 6 months ago

josh-allan commented 9 months ago

If building the Saml Reader from scratch, the dependencies will install Werkzeug version 3.0.1 as the packages will just update to the most recent version. This introduces breaking changes in the import of packages specifically in the import for Werkzeug.urls functions.

When running saml_reader with version 3.0.1 it throws a stack trace that results in:

ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/opt/homebrew/lib/python3.9/site-packages/werkzeug/urls.py)

This can be easily resolved by downgrading the package back to 2.2.2. I have opened a PR to resolve this.

clegaspi commented 7 months ago

I think that by upgrading dash and dash-extensions, this fixes this, as I did in #88 but I will look at it more closely on an M1 machine too.

clegaspi commented 6 months ago

Confirmed this as working on M1. I will revert the documentation changes shortly.