cli-playground / kodo

MIT License
0 stars 6 forks source link

Issue:13 Make a deployment accessible using a public URL #17

Closed Shraddhak22 closed 4 years ago

Shraddhak22 commented 4 years ago

Changes: Implemented service creation and route creation integrated with kodo deploy

Co-Author - Jaideep Rao Screenshot from 2020-06-18 17-09-52

sbose78 commented 4 years ago

Shraddha, could you confirm if the route URL works?

jaideepr97 commented 4 years ago

The route url is created, but doesn't point to anything since its just a deployment not an actual image

Shraddhak22 commented 4 years ago

Command to run - deploy --token="token"--server="server" --image=openshift/hello-openshift:latest --replicas="no of replicas" --port="port number" --namespace="namespace"

sbose78 commented 4 years ago

As far as I remember, openshift/hello-openshift:latest is an actual image which if deployed and exposed using a service+route, should be reachable over http.

ranakan19 commented 4 years ago

I was able to run this and deploy an image to cluster, Looks good to me.

ranakan19 commented 4 years ago

As far as I remember, openshift/hello-openshift:latest is an actual image which if deployed and exposed using a service+route, should be reachable over http.

I was to get a route over http and the webpage said "Hello Openshift", is this what you are referring to?

ranakan19 commented 4 years ago

As far as I remember, openshift/hello-openshift:latest is an actual image which if deployed and exposed using a service+route, should be reachable over http.

I was to get a route over http and the webpage said "Hello Openshift", is this what you are referring to?

http://myroute-prtest.apps.dev-svc-4.5-061813.devcluster.openshift.com/ is the route i got

sbose78 commented 4 years ago

Yes that's what I was referring to! Thank you :)

Shraddhak22 commented 4 years ago

All the changes suggested for this PR, has been covered in, https://github.com/cli-playground/kodo/pull/20. Adding @jaideepr97 in thread.