clingen-data-model / clinvar-ingest

Apache License 2.0
2 stars 0 forks source link

`rcv_accession_id` missing from `clinical_assertion` table #234

Closed theferrit32 closed 1 month ago

theferrit32 commented 1 month ago

This column exists in the DSP schemas and ours but is not populated in ours.

This value is technically redundant since it is inferred by matching the SCV traitset to the RCV traitset.

In the new pipeline it is also redundant and less reliable than the rcv_mapping table which has the direct relationship between RCV and SCV(s).

theferrit32 commented 1 month ago

@larrybabb we should discuss whether this field should be implemented or whether we should drop it in the new schemas

theferrit32 commented 1 month ago

Closing. Based on tuesday discussion we don't need to add this directly to the clinical_assertion table. It will be looked up from the rcv_mapping table.