search

clipmove / NotBlood

Gameplay Mod For NBlood
https://github.com/clipmove/NotBlood/releases
62 stars 3 forks source link

Increase MAXVOXELS value #110

Closed paolo-bolzoni closed 5 months ago

paolo-bolzoni commented 5 months ago

I wanted to use Blood Coagulated and Blood Voxel Pack and, first of all, thanks for putting clear instructions on the autoload folder; unfortunately the game then gives the error definevoxel: maximum number of voxels.

I tried recompiling increasing the value of MAXVOXELS (from source/build/include/build.h) to 4096 and everything seems to work fine. I did not try to lower it, probably less is enough.

Would it be possible to have releases with increased the MAXVOXELS value?

(Incidentally, with custom difficulty level 4-2-4-1-0-OFF-OFF, no hit scan cultist, and voxels... this is really an excellent way to play the game. The other mutators are also nice, but these make the difference for me. Thanks for the great job in NotBlood.)

https://www.moddb.com/mods/blood-coagulated https://www.moddb.com/mods/blood-voxel-pack

tmyqlfpir commented 5 months ago

Hi, thanks for trying out the fork and report.

eDuke did have it set to 4096 for a while, but eventually reduced it to 1024 for unknown reasons. This would be best addressed upstream on the NBlood repo as an issue so eDuke maintainers can weight in on this.

paolo-bolzoni commented 5 months ago

The game in the second level is unable to save, or better it saves but then it is unable to load. NotBlood crashes with a window stating: "Assetion failed: nSprite >= 0 && nSprite < kMaxSprites in file source/blood/src/seq.cpp at line 98.

So I guess there are problems increasing that value? Stll, since the game cannot load the mods with the usual MAXVOXELS value it is hard to say if that's the problem or something else.

(I used the code from commit 4325a220e, tagged latest)

[Edit: I tried to restart from the first level and I cannot replicate anymore... I am confused.]

tmyqlfpir commented 5 months ago

The game in the second level is unable to save, or better it saves but then it is unable to load. NotBlood crashes with a window stating: "Assetion failed: nSprite >= 0 && nSprite < kMaxSprites in file source/blood/src/seq.cpp at line 98.

If an enemy was to gib underneath a door or a sprite was to spawn on an invalid sector, it'll usually show this error message as it will attempt to animate a non-existent sprite. This happened on the original DOS version, and is difficult to recreate due to the RNG factors involved. Most of these cases have been fixed by NBlood but there are some lingering issues that have yet to be fixed.