search

clipmove / NotBlood

Gameplay Mod For NBlood
https://github.com/clipmove/NotBlood/releases
62 stars 3 forks source link

Some suggestions/bugs #111

Closed Mundyyy closed 5 months ago

Mundyyy commented 5 months ago

Here's some suggestions for stuff to add and some bugs:

[Suggestions]

Fly command - Useful for mapping. I test maps frequently using notblood

Spectating for deathmatch - Having it announce to the server when a player is spectating (to prevent cheating) and also being able to disable spectating all together in the bloodbath settings. Also having this off by default is preferable.

[Bugs]

  1. Seems like there's a bug with the gargoyles that spawn on e3m1 when you pick up the moon key using the randomizer. Randomized enemies just fly in the air while spinning. I'm guessing this only happens specifically to gargoyles placed in the air that don't immediately spawn when the map starts? https://youtu.be/VnKgxg6whzE

  2. Sometimes it seems like you can't switch teams. Not sure why. It's been an issue for awhile now. https://youtu.be/vZff3MwI1J0

tmyqlfpir commented 5 months ago

Fly command

I'll look into it.

Spectating for deathmatch

It's not really possible without refactoring all of the multiplayer code, as it's designed around each client connected is a valid player. This would be better suggested upstream.

Seems like there's a bug with the gargoyles that spawn on e3m1 when you pick up the moon key using the randomizer. Randomized enemies just fly in the air while spinning. I'm guessing this only happens specifically to gargoyles placed in the air that don't immediately spawn when the map starts?

Fixed.

Sometimes it seems like you can't switch teams. Not sure why. It's been an issue for awhile now.

Is auto teams off? I cannot recreate this issue.

Mundyyy commented 5 months ago

Is auto teams off? I cannot recreate this issue.

I'm not sure how to recreate it but I do have more examples of it happening with 4 players. The setting is off by default so we definitely had it off. It also seems the "team X" console command also isn't working.

tmyqlfpir commented 5 months ago

Technically this should work but there might be an issue where the packets are not being set to every client which could cause a desync. Steps to recreate it would be useful as I am unable to get it to happen on my local setup.

Mundyyy commented 5 months ago

I guess a better way to phrase it is I'm not sure what causes it. Now that I'm looking here I don't have footage of the bug happening when I switch the map, so I'm not sure what the exact steps are or the settings that were chosen, sorry. Though I'm still positive auto teams were off. Next time it happens I'll try to get more info

tmyqlfpir commented 5 months ago

I've added a unique message when attempting to change teams while auto team setting is on for the current match. If this does happen again and auto teams is off, then that is a bug.

tmyqlfpir commented 5 months ago

If this is still an issue please reopen this issue, otherwise thanks for the report.

Mundyyy commented 4 months ago

Can you open this issue again? Not related to the teams thing, but I found the same bug I mentioned about e3m1 with the randomized gargoyles on e6m1. It seems my theory was correct. If the map has gargoyles that do not spawn when the map starts and only spawns after a specific trigger (like grabbing a key), they will do what they did in the video I originally posted. I also found this issue in an addon, Fleshed Out. I don't remember which level it was but if you need to know I'll find out. Is there a universal fix for this or would you have to fix each individual level?

The gargoyles spawn when you enter the attic area next to the office that leads to the roof

tmyqlfpir commented 4 months ago

Hi. I'm unable to recrate this issue as the fix for gravity should properly init the sprites for trigger spawn actors. Here you can see the spawned two enemies now have gravity set, and if they were gargoyles the opposite would be true.

https://github.com/clipmove/NotBlood/assets/80724828/dff6e37c-87b0-4d52-b8a6-03bf3b3934b4

Do you have more information so I can debug this? Thanks.

Edit: Additional testing in E6M1 also shows the replaced spawned gargoyles dropping to the ground.

Mundyyy commented 4 months ago

Weird, e3m1 IS fixed for me but e6m1 and the addon level I mentioned still aren't working properly. That's why I thought maybe the maps had to be changed individually. Anyways here's another video, included the mutators as well if it means anything important https://www.youtube.com/watch?v=kTymXGTfZFg

Edit: Ok now they're falling like normal. My notblood version was out of date but I know for a fact that I updated after you fixed e3m1. Were there any changes made since?

Edit 2: OK I think I might be getting mixed up here. I have about 3 to 4 seperate notblood builds I use consistently so I don't think I updated the I'm using shown in the video but I did update the others.

Disregard. Everything is working as normal.